-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for installing fonts #1860
Conversation
Do we really want this? I mean, if you’re that interested in automating the installation of and use that many fonts, shouldn’t you be using a font manager anyway? Having a lot of fonts installed is one of the best ways to make sure your computer slows down considerably. |
Being able to install fonts this way sounds useful to me. I end up installing Inconsolata everywhere I go, and I'd rather do it through a package manager like this. DejaVu has a lot of fonts, though. Maybe each family should be a separate cask? |
Wow - this is badass! 👊 I've always found installing fonts to be a gross process of my machine setup process. I never thought that homebrew-cask could work for them. Nice work! |
add support for installing fonts
This should not be needed for .qlgenerator or .prefPane, because (like .app) those are always directories/bundles and therefore must be transported in some type of container.
Allow naked OTF and TTF files, follow-up on #1860
This should not be needed for .qlgenerator or .prefPane, because (like .app) those are always directories/bundles and therefore must be transported in some type of container.
Hm. Jackpot? |
I just want to make sure that font licensing is being respected. Hopefully on a project like this, it wouldn't need to be said, but it can get nasty quickly if it gets quasi-legal. |
Agreed. And this one is tricky. Although I believe DMG agreements have a clear answer, this one does not. We could argue that in this case it is the responsibility of the user to know in which cases the typefaces can and cannot be used, but facilitating their installation in this way can make that a bit blurry. I propose we shift every font to a new tap, and clearly state in the README that the user should read the individual licenses before using them (if they really do or not is out of our control and responsibility). We’ll be separating the regular casks from the main project anyway, eventually, so it’s not like this would be a big inconvenience, but it would be a nice step in preventing licensing issues. |
See also: https://code.google.com/multiple_licenses.html which is the case for https://code.google.com/p/googlefontdirectory/ |
Debian should be a good point of reference here. They have a more conservative philosophy about which packages can be included, and are further constrained in legal terms as they actually store and redistribute packages. In addition, they have had the benefit of extensive legal review. I note that although Debian packages many font binaries, Microsoft Core Fonts[1] are only installed via a virtual package which executes an installer, as @kevinSuttle I have reviewed the licenses of all fonts prior to submitting. The only unusual cases are where the font author does not provide a standard license, just says "hey these are free to use". I don't know if you followed the saga of the Code2000 font family. In that case, the author walked away, leaving things in a confusing state. FreeBSD determined that it was permissible to redistribute Code2000 and Code2001, and the submitted casks use FreeBSD servers for As licensing issues are not specific to fonts, and as it is in everyone's interest to be legal, ethical, and respectful, should we not add a "license" stanza to the cask format? Most binaries will be covered by the top 10 standard licenses. That information could be used in various helpful ways, beginning with getting statistics on the scope of any licensing issues. [1] http://packages.debian.org/wheezy/ttf-mscorefonts-installer |
Ha, this issue just came up in #2075. Envy Code R is a font that didn't pass my review. It is probably legal to Cask it, but it doesn't seem respectful to do so. |
@rolandwalker Agreed, I have asked @xcezx if he got permission from the author. |
@rolandwalker I really like the license stanza idea. |
@nanoxd Even if permission was obtained, what if the author has a change of heart later on? Unless we can post proof of the permission as well, for posterity, I say we refuse any font that doesn’t meet the criteria. |
@vitorgalvao That would be the most optimal approach. It stops PRs from sitting there for however long negotiations take 🏮 |
+1 here -> I'm strapped for time at the moment but I spun up https://github.com/caskroom/homebrew-fonts in case someone else wants to shovel them over. Otherwise I can pick this up tonight or tomorrow. |
The fonts in https://code.google.com/p/googlefontdirectory/ use 1 of 2 licenses (technically 3, but I'm disregarding Ubuntu). Either OFL or Apache. A good FAQ on OFL here. Both licenses seem to indicate that it's perfectly legal to redistribute the fonts within the repo as long as the original licenses are part of the distributions. Even the copyrights seem to be congruent to this notion. What do you think? |
Quick question regarding installing fonts with I'm on a fresh install of Mavericks, installed Homebrew (with brew-cask) and tapped Unfortunately, OS X doesn't appear to follow the symlinks in Have I missed a step or a setting somewhere? Thanks for the help! Painfully Detailed Steps to Reproduce
|
This is true. I just noticed myself. How were you pulling this off @rolandwalker? |
Strange -- I can duplicate the issue, though at the time of implementation this code was tested under a fresh user account. Furthermore, I had tested linking a containing dir under Some Googling suggests that symlinks and fonts don't always work together http://www.ninisworld.com/thecorner/tutorials/osxfonts.html In testing, I find that hard links to individual font files do always work as expected. Drawbacks: 1) can't hardlink if Surprisingly, Finder aliases to font files do not work at all. This link http://www.jklstudios.com/misc/osxfonts.html claims that a cache kept by Font Book can cause problems. I cannot duplicate that. |
Interesting. A stop-gap would be to The benefit of keeping track and automating downloads is still there. Thoughts? |
Just tested this in Mavericks, so YMMV depending on OS, but copying/moving files into Would it be possible with fonts to |
@phinze has said elsewhere he is willing to entertain the notion of I propose incremental change instead: we |
@jgarber623 Definitely didn't work for me. @rolandwalker I think hard links might work. |
I used a different naming scheme for the example cask, prefixing it with
font-
(font-dejavu.rb
) I think some name collisions are inevitable otherwise.It would also be possible to link just the directory
dejavu-fonts-ttf-2.34
into~/Library/Fonts
instead of linking each individual font. I don't know if you would consider that to be preferable.