Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix uninstall for ruby 2.0, multiple uninstall stanza, more #4804

Merged
merged 5 commits into from
Jun 10, 2014
Merged

fix uninstall for ruby 2.0, multiple uninstall stanza, more #4804

merged 5 commits into from
Jun 10, 2014

Conversation

rolandwalker
Copy link
Contributor

@rolandwalker
Coerce :files to Array in uninstall
b65cbbf 
before invoking `each` method.  This is necessitated by Homebrew's
switch to Ruby 2.0.

Also standardize how all `uninstall` directives are coerced to Array,
in a way that is compatible between Ruby 1.8 and 2.0.

Fixes Homebrew#4784.
@rolandwalker
More robust :signal directive in DSL
974877a 
Coerce more variations into pairs.
@rolandwalker
uninstall :files in chunks
f534bbd 
micro-optimization; minimize shell invocations
@rolandwalker
improve :signal debug message
9fdae45
@nanoxd
Copy link
Contributor

nanoxd commented Jun 10, 2014

Why not include a test for multiple uninstall stanzas?

@rolandwalker
Copy link
Contributor Author

Improvement from removing files in slices? It depends on how many files there are. With #2263, the mactex.rb uninstall became an order of magnitude faster. Here, the number of files is generally much smaller, but we were discussing one Cask lately (#4759) where putting a Dir.glob() expression into :files is a possibility.

You mean add multiple install stanzas to the test suite, or add a check to disallow them as we do with eg url? I didn't even look into the test suite there. As far as I know, multiple uninstall has always been documented to work, but definitely has not worked correctly for a long time.

@rolandwalker
allow multiple uninstall stanzas to work
65a4cc6 
fixes longstanding bug; aligns code with docs
@rolandwalker rolandwalker mentioned this pull request Jun 10, 2014
Closed
rolandwalker added a commit that referenced this pull request Jun 10, 2014
@rolandwalker
Merge pull request #4804 from rolandwalker/uninstall_coerce_ruby_2.0
caf6c14 
fix uninstall for ruby 2.0, multiple uninstall stanza, more
@rolandwalker rolandwalker merged commit caf6c14 into Homebrew:master Jun 10, 2014
@rolandwalker rolandwalker deleted the uninstall_coerce_ruby_2.0 branch June 10, 2014 22:21
@rolandwalker rolandwalker mentioned this pull request Jun 11, 2014
Closed
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rolandwalker @nanoxd