Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demote implicit Cask path sources (i.e. files in current working directory) #4658

Merged

Conversation

rolandwalker
Copy link
Contributor

Don't prefer Cask files in the cwd (fixes #4641.) Cask files in the cwd are
still permitted, but at the very lowest priority, below Tapped Cask names.

Also add to_s methods to all sources and show resolved Cask source when
using --debug.

Fixes Homebrew#4641.  Cask files in the cwd are still permitted, but
at the very lowest priority, below Tapped Cask names.
rolandwalker added a commit that referenced this pull request Jun 3, 2014
Demote implicit Cask path sources (i.e. files in current working directory)
@rolandwalker rolandwalker merged commit 96ebb64 into Homebrew:master Jun 3, 2014
@deiga
Copy link
Contributor

deiga commented Jun 4, 2014

Did this also fix the cwd lookup for brew cask list?

@rolandwalker
Copy link
Contributor Author

brew cask list <caskname> also does ignores files in the cwd (unless the named Cask is not present in a Tap).

The issue with file extensions also appears to have been fixed with these changes. I'm trying to decide when to cut a release: maybe today, certainly by Saturday.

Thanks for the report, and for the followups on these important details.

@rolandwalker rolandwalker deleted the demote_implicit_path_source branch October 3, 2014 20:58
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while installing amethyst
2 participants