Fix commit range for audit_modified_casks
#13783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value of TRAVIS_COMMIT_RANGE is of the form: <target_branch_tip>...<pr_branch_tip> Even after replacing the '...' with '..', this results in unrelated changes being included in the diff if the target branch (usually master) has been updated since the PR branch was created. The commit that Travis checks out for testing (TRAVIS_COMMIT) is a merge of the PR branch into the target branch (TRAVIS_BRANCH), so the commit range TRAVIS_BRANCH..TRAVIS_COMMIT should only include the changes from the PR.
jawshooah
changed the title
audit_modified_casks
vitorgalvao
added a commit
that referenced
this pull request
Sep 16, 2015
Fix commit range for `audit_modified_casks`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of
TRAVIS_COMMIT_RANGEis of the form<target_branch_tip>...<pr_branch_tip>. Even after replacing the...with..in #13762, this results in unrelated changes being included in the diff if the target branch (master) has been updated since the PR branch was created.The commit that Travis checks out for testing (
TRAVIS_COMMIT) is a merge of the PR branch into the target branch (TRAVIS_BRANCH), so the commit rangeTRAVIS_BRANCH..TRAVIS_COMMITshould only include the changes from the PR.