Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show DMG agreements by default #13593

Closed
vitorgalvao opened this issue Sep 4, 2015 · 9 comments
Closed

Show DMG agreements by default #13593

vitorgalvao opened this issue Sep 4, 2015 · 9 comments
Labels
core Issue with Homebrew itself rather than with a specific cask. enhancement outdated ready to implement stale Issue which has not received any feedback for some time.

Comments

@vitorgalvao
Copy link
Contributor

References #720. Some preliminary work done (and abandoned) in #8231.

How the system should work:

  • Show DMG agreements by default.
    • This is a blocking operation (i.e. the user has to type y or n to agree or not, before continuing).
    • The license is redirected to less, for easy reading and so terminal output doesn’t get cluttered.
      • If they agree, the installation continues.
      • If they disagree, the installation of that particular package aborts and the rest (if any) continue.
  • Have a --blindly-accept-licenses1 flag that will auto-accept agreements for that command.
    • This also works if set in HOMEBREW_CASK_OPTS.
    • In this case, the license won’t even be printed to output, and the user won’t be warned.

1 The use of “blindly”, as suggested by @MattiSG, has power.

@vitorgalvao vitorgalvao added enhancement core Issue with Homebrew itself rather than with a specific cask. labels Sep 4, 2015
@jawshooah
Copy link
Contributor

It's worth mentioning that implementation of this feature is blocked by #8231. There's nothing to stop us from picking up @claui's work and moving forward, though.

@vitorgalvao
Copy link
Contributor Author

@claui has been absent from the project for a long time, and hasn’t even replied on that issue so we should consider that dead, and just pick up whatever’s useful.

@Amorymeltzer
Copy link
Contributor

Just popping in to reiterate my previous comment. A simple one-line message, whether the default or with another flag, telling the user what they blindly agreed to would be welcome.

@MattiSG
Copy link
Contributor

MattiSG commented Dec 2, 2015

👍

@stale
Copy link

stale bot commented Feb 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Issue which has not received any feedback for some time. label Feb 7, 2019
@vitorgalvao vitorgalvao removed the stale Issue which has not received any feedback for some time. label Feb 8, 2019
@reitermarkus
Copy link
Member

@vitorgalvao, I think this is actually implemented, but only shown with --verbose.

@vitorgalvao
Copy link
Contributor Author

@reitermarkus But that is that ever a blocking operation that the user has to agree to before continuing?

@reitermarkus
Copy link
Member

No, it doesn't block. Honestly, I think we should just close this. Nobody has complained or shown any interest in this in 4 years.

@stale
Copy link

stale bot commented Mar 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Issue which has not received any feedback for some time. label Mar 9, 2019
@stale stale bot closed this as completed Mar 16, 2019
@lock lock bot added the outdated label Apr 15, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core Issue with Homebrew itself rather than with a specific cask. enhancement outdated ready to implement stale Issue which has not received any feedback for some time.
Projects
None yet
Development

No branches or pull requests

5 participants