Make symlink targets writeable, so we can write altnames #11200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
added
bug
|
@rolandwalker will you review this, please? |
|
Any news on getting this PR assigned/merged - issue with permissions seems to be same on Mavericks? Thanks |
|
This looks fine to me. @vitorgalvao, are you comfortable with merging this? |
|
Yes. |
jawshooah
added a commit
that referenced
this pull request
Aug 3, 2015
Make symlink targets writeable, so we can write altnames
miccal
removed
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9667.
I was also thinking if I should first read the existing set of permissions, change it, run
xattrand then change it back as it was, so that nobody knows we were here 😸but since we're already changing the content of that app my writing the alt name, I don't think it's necessary.