Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promises in the NUT09 response should be named signatures #201

Open
thesimplekid opened this issue Oct 30, 2024 · 4 comments · Fixed by #234
Open

Promises in the NUT09 response should be named signatures #201

thesimplekid opened this issue Oct 30, 2024 · 4 comments · Fixed by #234

Comments

@thesimplekid
Copy link
Contributor

https://github.com/cashubtc/nuts/blob/main/09.md

if (!isObj(data) || !Array.isArray(data?.outputs) || !Array.isArray(data?.promises)) {

@mubarak23
Copy link
Contributor

the response has a data with following shape

{
  "outputs": <Array[BlindedMessages]>,
  "signatures": <Array[BlindSignature]>
}

so essentially we are changing

data?.promises

to

data?.signatures

am correct here @thesimplekid

@thesimplekid
Copy link
Contributor Author

am correct here @thesimplekid

I don't know the cashu-ts code base there maybe other places it needs to be changed.

@mubarak23
Copy link
Contributor

am correct here @thesimplekid

I don't know the cashu-ts code base there maybe other places it needs to be changed.

yes, i will do some lookup on this

@gandlafbtc
Copy link
Collaborator

#234

@gandlafbtc gandlafbtc linked a pull request Feb 20, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants