Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Spotless #516

Closed
veyndan opened this issue May 2, 2022 · 1 comment · Fixed by #637
Closed

Use Spotless #516

veyndan opened this issue May 2, 2022 · 1 comment · Fixed by #637

Comments

@veyndan
Copy link
Contributor

veyndan commented May 2, 2022

I've noticed that some PRs are implementing one thing but then tidying up the formatting/adding license headers to seeming unrelated files (which is awesome) but I think we can slightly reduce the cognitive load of the reviewers by enforcing that these things are fixed (as much as possible) at the time of implementation. We can use Spotless to fix the formatting via ktlint and enforce license headers.
@swankjesse
Copy link
Collaborator

Make it so.

@veyndan veyndan mentioned this issue Aug 9, 2022
Merged
@adrw adrw changed the title Use Spotless Use Kotlinter Aug 12, 2022
@veyndan veyndan changed the title Use Kotlinter Use Spotless May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Spotless cashapp/zipline
2 participants
@swankjesse @veyndan