Skip to content

Commit 441a968

Browse files
authoredOct 14, 2024
Merge pull request #287 from casangi/268-processing-set-and-correlated-data-functionality
Fix links.
2 parents e4e4ffe + 6c8df29 commit 441a968

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed
 

‎docs/source/measurement_set_overview.ipynb

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"source": [
77
"# Overview\n",
88
"\n",
9-
"The Measurement Set v4 (MS v4) schema defines how correlated data (interferometer visibilities and single-dish spectra) can be represented in memory using datasets that consist of n-dimensional arrays labeled with coordinates and meta-information contained in attributes (see [foundational reading](https://xradio.readthedocs.io/en/latest/overview.html#Foundational-Reading)). The MS v4 implementation differs from the `MS v2` implementation in [`casacore`](https://github.com/casacore/casacore) primarily in its use of Python and off-the-shelf packages for data structures and data serialization, contrasting with `casacore's` bespoke C++ approach.\n",
9+
"The Measurement Set v4 (MS v4) schema defines how correlated data (interferometer visibilities and single-dish spectra) can be represented in memory using datasets that consist of n-dimensional arrays labeled with coordinates and meta-information contained in attributes (see [foundational reading](https://xradio.readthedocs.io/en/latest/overview.html#Foundational-Reading)). The MS v4 implementation differs from the `MS v2` implementation in [casacore](https://github.com/casacore/casacore) primarily in its use of Python and off-the-shelf packages for data structures and data serialization, contrasting with `casacore's` bespoke C++ approach.\n",
1010
"\n",
1111
"Reference documents consulted for the MS v4 schema design:\n",
1212
"\n",
@@ -177,7 +177,7 @@
177177
" </figure>\n",
178178
"</div>\n",
179179
"\n",
180-
"[Figure 3](#figure-3) summarizes the available and planned future functionality. The sub-package currently allows direct opening of data from [zarr](https://zarr-specs.readthedocs.io/en/latest/specs.html) and will support WSU ASDM (Wide Band Sensitivity Upgrade) and [NetCDF](https://www.unidata.ucar.edu/software/netcdf/) in the future. The WSU ASDM is an update of the [ASDM](https://drive.google.com/file/d/1PMrZFbkrMVfe57K6AAh1dR1FalS35jP2/view) implementation required by [ALMA WSU](https://science.nrao.edu/facilities/alma/science_sustainability/wideband-sensitivity-upgrade) where the spectral windows are no longer interleaved. Both zarr and NetCDF support cloud storage, and [`open_processing_set`](https://xradio.readthedocs.io/en/latest/measurement_set/schema_and_api/measurement_set_api.html#xradio.measurement_set.open_processing_set) and [`load_processing_set`](https://xradio.readthedocs.io/en/latest/measurement_set/schema_and_api/measurement_set_api.html#xradio.measurement_set.load_processing_set) support accessing data on [Amazon S3](https://aws.amazon.com/s3/).\n",
180+
"[Figure 3](#figure-3) summarizes the available and planned future functionality. The sub-package currently allows direct opening of data from [zarr](https://zarr-specs.readthedocs.io/en/latest/specs.html) and will support WSU ASDM (Wide Band Sensitivity Upgrade) and [NetCDF](https://www.unidata.ucar.edu/software/netcdf/) in the future. The WSU ASDM is an update of the [ASDM](https://drive.google.com/file/d/1PMrZFbkrMVfe57K6AAh1dR1FalS35jP2/view) implementation required by [ALMA WSU](https://science.nrao.edu/facilities/alma/science_sustainability/wideband-sensitivity-upgrade) where the spectral windows are no longer interleaved. Both zarr and NetCDF support cloud storage, and [open_processing_set](https://xradio.readthedocs.io/en/latest/measurement_set/schema_and_api/measurement_set_api.html#xradio.measurement_set.open_processing_set) and [load_processing_set](https://xradio.readthedocs.io/en/latest/measurement_set/schema_and_api/measurement_set_api.html#xradio.measurement_set.load_processing_set) support accessing data on [Amazon S3](https://aws.amazon.com/s3/).\n",
181181
"\n",
182182
"<div style=\"text-align: center;\">\n",
183183
" <figure id=\"figure-3\" style=\"display: inline-block;\">\n",

‎docs/source/overview.ipynb

+3-3
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@
122122
"cd xradio\n",
123123
" pip install -e \".[all]\"\n",
124124
"```\n",
125-
"The `-e` ensures that the installation location is the same as the cloned repository (using `pip list` should show this), so that you can directly modify the cloned repo. The `[all]` ensures that all dependencies so that you can run the interactive Jupyter notebooks and build the documentation (the dependencies can be found in the [`pyproject.toml`](https://github.com/casangi/xradio/blob/main/pyproject.toml)).\n",
125+
"The `-e` ensures that the installation location is the same as the cloned repository (using `pip list` should show this), so that you can directly modify the cloned repo. The `[all]` ensures that all dependencies so that you can run the interactive Jupyter notebooks and build the documentation (the dependencies can be found in the [pyproject.toml](https://github.com/casangi/xradio/blob/main/pyproject.toml)).\n",
126126
"\n",
127127
"### Building documentation\n",
128128
"\n",
@@ -144,12 +144,12 @@
144144
"- **Docstrings**: All functions and classes should include NumPy-style docstrings. For guidelines, refer to the [NumPy Documentation Guide](https://numpydoc.readthedocs.io/en/latest/format.html).\n",
145145
"- **Compute-Intensive Code**: Ensure that compute-intensive code is vectorized for performance. If vectorization is not feasible, consider using [Numba](https://github.com/numba/numba). Use performance testing to verify that optimizations are effective.\n",
146146
"- **Testing**: Write unit tests for all major functions and classes using [pytest](https://docs.pytest.org/en/latest/). The folder structure of `xradio/tests/unit` should mirror the source code structure.\n",
147-
"- **Error Handling & Logging**: Use the [`toolviper`](https://github.com/casangi/toolviper/blob/main/docs/graphviper-logger-formatting-example.ipynb) logger for consistent logging.\n",
147+
"- **Error Handling & Logging**: Use the [toolviper](https://github.com/casangi/toolviper/blob/main/docs/graphviper-logger-formatting-example.ipynb) logger for consistent logging.\n",
148148
"\n",
149149
"### Submitting Code\n",
150150
"\n",
151151
"- Any code you submit is under the [BSDv3 license](https://github.com/casangi/xradio/blob/main/LICENSE.txt) and you will have to agree with our [contributor license agreement](https://github.com/casangi/xradio/blob/main/CONTRIBUTOR_LICENSING_AGREEMENT.txt) that protects you and the XRADIO project from liability.\n",
152-
"- Create an issue on github outlining what you would to contribute [`XRADIO GitHub repository](https://github.com/casangi/xradio/issues).\n",
152+
"- Create an issue on github outlining what you would to contribute [XRADIO GitHub repository](https://github.com/casangi/xradio/issues).\n",
153153
"- Once there is agreement on the scope of the contribution you can create a branch on github or in you clones repository:\n",
154154
"```sh\n",
155155
" git checkout -b feature-or-fix-name\n",

0 commit comments

Comments
 (0)