Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not use escape brackets for forward_title and back_title #98

Closed
zkamvar opened this issue Nov 7, 2023 · 0 comments · Fixed by #101
Closed

do not use escape brackets for forward_title and back_title #98

zkamvar opened this issue Nov 7, 2023 · 0 comments · Fixed by #101
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@zkamvar
Copy link
Contributor

zkamvar commented Nov 7, 2023

I was going through old issues and I realize this is a bug from {varnish}, not {sandpaper}. Specifically, this is caused by the Mustache templating escaping values.

So any place that contains {{forward_title}} or {{back_title}} needs to be changed to either include an ampersand or triple curlies (see https://mustache.github.io/mustache.5.html):

<a class="chapter-link float-end" href="{{#site}}{{root}}{{/site}}{{page_forward}}" rel="next">
{{#forward_title}}Next: {{forward_title}}... {{/forward_title}}{{^forward_title}}Home{{/forward_title}}
<i aria-hidden="true" class="small-arrow" data-feather="arrow-right"></i>
</a>

Originally posted by @zkamvar in carpentries/workbench#71 (comment)

@zkamvar zkamvar added bug Something isn't working good first issue Good for newcomers labels Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant