Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contrast issue for (non-Rmarkdown) figure caption with dark theme #143

Closed
Bisaloo opened this issue Jun 20, 2024 · 3 comments · Fixed by #145
Closed

Contrast issue for (non-Rmarkdown) figure caption with dark theme #143

Bisaloo opened this issue Jun 20, 2024 · 3 comments · Fixed by #145

Comments

@Bisaloo
Copy link
Contributor

Bisaloo commented Jun 20, 2024

See https://hugogruson.fr/workbench-darktheme-test/introduction.html, built directly from the workbench-template-rmd.

Captions for Rmarkdown figures seem fine but captions for standard markdown figures is light text on light background.

image
@froggleston
Copy link
Contributor

@astroDimitrios - would it be possible for you to take a look at this? Or point us in the direction of a fix? Thanks in advance! :)

@astroDimitrios
Copy link
Contributor

@froggleston I will take a look Monday :)

@froggleston
Copy link
Contributor

Fantastic - thank you!

@astroDimitrios astroDimitrios mentioned this issue Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix dark mode figcaption bug astroDimitrios/varnish
3 participants
@froggleston @Bisaloo @astroDimitrios