Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"make serve" forces global config change to bundle #239

Closed
wirawan0 opened this issue Dec 8, 2020 · 1 comment · Fixed by #240
Closed

"make serve" forces global config change to bundle #239

wirawan0 opened this issue Dec 8, 2020 · 1 comment · Fixed by #240

Comments

@wirawan0
Copy link

wirawan0 commented Dec 8, 2020

Hi, I noticed the recent change in JEKYLL var in lesson's Makefile leads to a global change in my ~/.bundle/config that is undesirable. I have MacOS with ruby fed from Homebrew. I have been installing all the Jekyll gem dependencies to build Carpentry-style webpages with "bundle install" once, and for all lessons I was able to simply run "bundle exec make serve". But the recent change to hpc-intro in commit 4b880e3 causes .vendor/bundle to be set for every lesson repo I have--causing fatal error every time I wanted to compile lessons other than hpc-intro. Turned out that this config would force me to do "bundle install" for every lesson repo I have (and I have many of them--over 10). @ocaisa , may you please explain why the change in the JEKYLL definition in the first place? I am trying to avoid installing lesson-specific gems for every lesson if at all possible.

@ocaisa
Copy link
Contributor

ocaisa commented Dec 8, 2020

Hi @wirawan0 , when I made this change upstream in carpentries/styles#473 they caught that I was making a global config change but I forgot to merge the updates there back to this repo. That is now done in #240.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants