Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On fire() function, add display:flex #113

Closed
paulhalfpenny opened this issue Apr 5, 2016 · 1 comment
Closed

On fire() function, add display:flex #113

paulhalfpenny opened this issue Apr 5, 2016 · 1 comment

Comments

@paulhalfpenny
Copy link

I'm using display:flex to position my modal centrally on the page, but this is overriden by this function:

function fire() {
// You can use ouibounce without passing an element
// #30
if (el) el.style.display = 'block';
disable();
}

If you can change this line to:

if (el) el.style.display = 'block | flex';

it works fine. I don't use Github typically, so no PR, but thought I would highlight it so you could add it in if you have time (or a better way of implementing this change!).

@Kalabasa
Copy link

I think a better way is to use visibility so clients can use any display style they want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants