From c35c26d8449b4caa1c7d16ff091cebe84a48fdb1 Mon Sep 17 00:00:00 2001 From: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com> Date: Fri, 8 Oct 2021 15:46:24 +0400 Subject: [PATCH] Fix missing apply_to_spans in OTEP 0152 (#180) The OTEP text correctly says: >In addition it is also possible to optionally specify spans and events that the transformation should apply to. However, the block after that text is missing the apply_to_spans that the text alludes to. I wrote the text correctly but made a mistake when copy/pasting the yaml from my experimental codebase. I consider this to be a non-breaking change. It is a bug fix since the tag in yaml is supposed to be there according to the text. --- text/0152-telemetry-schemas.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/text/0152-telemetry-schemas.md b/text/0152-telemetry-schemas.md index e4c7d397fbe..041321013ab 100644 --- a/text/0152-telemetry-schemas.md +++ b/text/0152-telemetry-schemas.md @@ -425,7 +425,9 @@ only to events of spans that have the specified name. Here is the structure: This is similar to the "rename_attributes" transformation supported in "all" and "resource" sections. In addition it is also possible to optionally specify spans -and events that the transformation should apply to. Here is the structure: +and events that the transformation should apply to (both optional conditions +must match, if specified, for transformation to be applicable). Here is the +structure: ```yaml span_events: @@ -436,6 +438,9 @@ and events that the transformation should apply to. Here is the structure: # in the previous version, the values are the new attribute name # starting from this version. + apply_to_spans: + # Optional span names to apply to. If empty applies to all spans. + apply_to_events: # Optional event names to apply to. If empty applies to all events. ```