IPhone X support

[nyekimov]

Default implementation of the LicensesViewController doesn't respect safe area of the view and when you scroll through data it overlaps interactive controls at the very bottom of the screen. I believe the updateViewConstraints() needs to be updated per ios 11.

[carloe]

@nyekimov Thanks for this.

Could you elaborate on what kind of controls you are talking about / what your usecase is? From what I can see the LicensesViewController is working correctly when it's embedded in a UITabBarController. It also seems to have the correct content offsets when used in a UINavigationController.

[nyekimov]

The interactive controls at the very bottom of the screen is apple terminology from https://developer.apple.com/ios/human-interface-guidelines/overview/iphone-x/.

Attaching a screenshot on which text overlaps very bottom interactive controls. If I scroll till the end of the table view, bottom inset is in place. However text overlapping at scrolling isn't correct behavior. Bottom / Top layout guides should be used with constraints since ios 9. In iOS 11 apple introduces safe area which works perfectly if layout guides are in place.

Pushed a PR with a possible fix, please take a look.

[nyekimov]

actually checked another table views and usually content overlaps bottom controls. It's a normal behavior for table view cells. The behavior can be changed manually if developer wishes when developer has access to the view controller. Here is an issue that developer can't customize LicensesViewController.
Any suggestions?
Issue probably can be closed.

[carloe]

Thank you for clarifying!

I checked the docs you linked & looked at safari as reference, and I think the layout is behaving as it should. In portrait it matches what safari does, and in landscape it does take the safe zones into account. I believe they are talking about UITabBar, UIButton, UIToolbar, etc when they are talking about 'interactive controls' here.

Please let me know if you still disagree. Screenshots for reference (Safari, LicenseViewController scrolled to top, LicenseViewController scrolled to bottom, LicenseViewController in landscape mode):

[carloe]

Good point... The tableView property of LicensesViewController should probably be open. Then you should be able do what you are trying to do. What do you think?

[nyekimov]

@carloe yeah this should probably help.

[carloe]

@nyekimov ok, I will push that change with 0.6.5 as soon as the PR #21 build passes. Thanks again for the feedback!