Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics #44

Open
carllerche opened this issue Jul 30, 2018 · 4 comments
Open

Metrics #44

carllerche opened this issue Jul 30, 2018 · 4 comments

Comments

@carllerche
Copy link
Owner

No description provided.

@stuartnelson3
Copy link

Do you have a metrics backend in mind that you are interested in supporting?

@shepmaster
Copy link
Collaborator

Or even a set of metrics, which would lead to being able to decide what backend is useful 😇

Note that there is a log middleware which has some amount of overlap with the general umbrella of "metrics".

@stuartnelson3
Copy link

stuartnelson3 commented Aug 27, 2018

I would recommend following RED -- it's going to expose all of the metrics info that should be relevant to every webapp. Rate, Errors, and Duration, each partitioned by path/method/status code, and potentially resource name.

Generally metrics, logging, and tracing fall under the "observability" umbrella. In the case of tower-web, I think per route rate/errors/duration metrics could very easily be gathered as it's own middleware, as @shepmaster suggests.

I would be happy to contribute a prometheus middleware, if there were interest. I'm somewhat biased towards that backend since I'm a part of the project, though.

@carllerche
Copy link
Owner Author

This relates to tokio-rs/tokio#561. In the long run, I would like tower-web to emit Tokio trace events on a per route basis... this would enable the most flexibility.

@stuartnelson3 either way, a prometheus Tower middleware would be 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants