Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collisions are not annotated when vehicle's speed is low #13

Closed
nsubiron opened this issue Nov 7, 2017 · 2 comments · Fixed by #915
Closed

Collisions are not annotated when vehicle's speed is low #13

nsubiron opened this issue Nov 7, 2017 · 2 comments · Fixed by #915
Assignees
@nsubiron
Labels
bug c++ Requires changing C++ code
Milestone
0.9.1

Comments

@nsubiron
Copy link
Collaborator

nsubiron commented Nov 7, 2017

Currently there is a hard-coded limit of 1 km/h to avoid annotating unwanted collisions from other agents when the player is not moving (due to #7 mostly).

However, it seems to miss collisions when the car moves slightly faster too, around 5 km/h. This should be fixed because at 5 km/h the car is definitively moving.
@nsubiron nsubiron added the bug label Nov 7, 2017
@nsubiron nsubiron added the c++ Requires changing C++ code label Mar 14, 2018
@germanros1987
Copy link
Member

Is this bug still around?

@nsubiron
Copy link
Collaborator Author

Yup

@nsubiron nsubiron added this to the 0.9.1 milestone Oct 24, 2018
@nsubiron nsubiron mentioned this issue Oct 26, 2018
Merged
@ghost ghost removed the in progress label Oct 26, 2018
@seansegal seansegal mentioned this issue Dec 19, 2018
Open
@ShahriarSefati ShahriarSefati mentioned this issue Apr 20, 2020
Closed
@man-csl man-csl mentioned this issue Aug 31, 2020
Closed
@hellojql hellojql mentioned this issue Nov 2, 2020
Closed
@harmeeksinghbedi harmeeksinghbedi mentioned this issue Nov 11, 2020
Closed
@RehabHsn RehabHsn mentioned this issue Feb 3, 2022
Closed
@SampsonM8 SampsonM8 mentioned this issue Apr 23, 2023
Open
@Andrey949101 Andrey949101 mentioned this issue Oct 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nsubiron nsubiron

Labels
bug c++ Requires changing C++ code
Projects
None yet
Milestone
0.9.1
Development

Successfully merging a pull request may close this issue.

A few changes for 0.9.1 carla-simulator/carla
3 participants
@nsubiron @carla-admin @germanros1987