-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable peers #240
Comments
We have had a discussion on the configurable peers and while we developed it to a point where we could have merged something like this, the overall UX and goal of the story was not where @abailly and me felt it should be going. It's a bit sad, but we decided to park this for now. Keep it on a branch, demo it, but not merge and release it on 0.7.0. Some details on what was lacking in the approach (not the implementation)
Concluding, this should tell us a story about being VERY clear on the WHY and the resulting user experience and/or having actual users to talk to along the way. |
What & Why
Right now, the
hydra-node
is configured on startup to which other nodes it is connecting to using command line arguments like--peer
. This is very inflexible, as it means the hostnames/IP addresses need to be known up-front and this becomes quickly unmanagable, especially in bigger, coordinated setups like benchmarks from #203 or #186.For that matter, this feature will add ways to modify peers during runtime of
hydra-node
via the API.For now, it shall not be possible to change the list of peers while the head is initialized or open. So only in
IdleState
.Also, we want to be using the existing API layer to keep this small and focused! (see below for more rationale)
How
ModifyPeers
Network
handle tomodifyPeers :: ([Peer] -> (a, [Peer])) -> m a
IdleState
Hydra.NodeLogic
module with a similarupdate
function, moving the event/effect types into a shared module, and handle these "node-level" concerns there. For other concerns it would delegate toHydra.HeadLogic.update
FAQ
IdleState
PeerConnected
anyways.The text was updated successfully, but these errors were encountered: