Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

date input to string conversion cause a moment js deprecation warning #85

Closed
seddik11 opened this issue Jul 7, 2020 · 2 comments
Closed

date input to string conversion cause a moment js deprecation warning #85

seddik11 opened this issue Jul 7, 2020 · 2 comments
Labels
P: Low S: work in progress T: bug Functionality that does not work as intended/expected

Comments

@seddik11
Copy link

seddik11 commented Jul 7, 2020 •
edited
Loading

https://github.com/Ideolys/carbone/blob/4859cf8d894fcbfa46253578d1cdec1093ac095e/formatters/date.js#L36

when I try to use the date formatter formatD moment js print a deprecation warning Deprecation warning: value provided is not in a recognized RFC2822 or ISO format but when i removed the concatenation + '' warning disappeared.
@seddik11 seddik11 changed the title date to string convertion cause a moment js error date input to string convertion cause a moment js error Jul 7, 2020
@seddik11 seddik11 changed the title date input to string convertion cause a moment js error date input to string conversion cause a moment js error Jul 8, 2020
@seddik11 seddik11 changed the title date input to string conversion cause a moment js error date input to string conversion cause a moment js deprecation warning Jul 8, 2020
@steevepay steevepay added P: Low S: work in progress T: bug Functionality that does not work as intended/expected labels Jul 8, 2020
@steevepay
Copy link
Member

Hi @seddik11, thank you for reaching us!
Since the latest release v2.0.0, we have updated the momentjs module and we didn't notice the warning.
We are going fix the issue but we need to investigate to see if it breaks or changes older reports.

@steevepay steevepay mentioned this issue Jul 10, 2020
Open
21 tasks
@steevepay
Copy link
Member

Version 3 of Carbone is available, Dayjs is used instead of Momentjs. You can directly switch to the latest version without breaking changes, everything is supported. Learn more:
https://github.com/carboneio/carbone/blob/master/CHANGELOG.md#v300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P: Low S: work in progress T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@steevepay @seddik11