Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report]: formatter result delete spaces #59

Open
floriantz opened this issue Dec 16, 2019 · 6 comments
Open

[Bug Report]: formatter result delete spaces #59

floriantz opened this issue Dec 16, 2019 · 6 comments
Labels
duplicate The issue has already been reported P: High S: on hold The issue is on hold until further notice T: bug Functionality that does not work as intended/expected

Comments

@floriantz
Copy link

floriantz commented Dec 16, 2019

Environment
Carbone Version: 1.2.1
Node Version: Node 10.15.X

Expected Behaviour
Formatters should return the result while conserving spaces

Actual Behaviour
formatters returns the formatted string with all spaces removed.

Maybe it is intended but having a way to avoid this behaviour would be most appreciated ! 👍

Steps to reproduce
template.odt :

{d.bool:ifEqual(true, “some sentence”)}

{d.test:ifEmpty(“some other sentence”)}

returns in pdf form:

somesentence

someothersentence

EDIT: had an issue with quotes but I was misled by documentation where they are always used inside formatter functions.

@floriantz floriantz added the T: bug Functionality that does not work as intended/expected label Dec 16, 2019
@floriantz floriantz changed the title [Bug Report]: when using :formatD result is always enclosed in quotes [Bug Report]: formatter result is always enclosed in quotes and delete spaces Dec 16, 2019
@floriantz floriantz changed the title [Bug Report]: formatter result is always enclosed in quotes and delete spaces [Bug Report]: formatter result delete spaces Dec 16, 2019
@steevepay
Copy link
Member

Hi @ZFLloyd,

First, thank you for your message.
We are already aware of this issue, it's closely related to an existing issue #44.
It is one of our next priorities for the next release.
Hold on, we will come back to you.

@steevepay steevepay added duplicate The issue has already been reported P: High S: on hold The issue is on hold until further notice labels Dec 16, 2019
@floriantz
Copy link
Author

floriantz commented Dec 17, 2019

Thanks for the quick response @steevepay ! Is there an ETA for the next release containing a bugfix for this?

@steevepay
Copy link
Member

@ZFLloyd middle or end of January 2020 maximum (or maybe sooner)

@jdim
Copy link

jdim commented May 7, 2020

Hi @steevepay
Are there any updates?

@steevepay
Copy link
Member

Hi @jdim, to give you updates: #9 (comment)
The issue is fixed for the next version.

@steevepay
Copy link
Member

It is fixed on the new version, check out the v2 branch on Github or directly NPM: npm install carbone@2.0.0-beta.0
The changes with examples are available on the changelog.

@steevepay steevepay mentioned this issue May 14, 2020
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate The issue has already been reported P: High S: on hold The issue is on hold until further notice T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

No branches or pull requests

3 participants