Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pagination] Change Select's label to "Page number" #17974

Closed
1 of 2 tasks
alina-jacob opened this issue Nov 5, 2024 · 2 comments · Fixed by #18166
Closed
1 of 2 tasks

[Pagination] Change Select's label to "Page number" #17974

alina-jacob opened this issue Nov 5, 2024 · 2 comments · Fixed by #18166

Comments

@alina-jacob
Copy link
Member

alina-jacob commented Nov 5, 2024

Acceptance criteria

  • Current implementation of the pagination nav can have an improved screen reader announcement.

Problem:
The screen reader announcement for the pagination component is a bit odd. It potentially announces "of 40 pages" twice.
This is the current implementation: Page number of 40 pages, 12

Solution:
Implement the label in a way that the screen-reader sounds similar to this: "Page, 12, of 40 pages".
PS: Combobox is the assigned role of the component.

  • Select's label for Pagination should read as "Page" instead of "Page number, of 40 pages".
  • Update website doc image to reflect the same (issue here)

Image

@preetibansalui
Copy link
Contributor

preetibansalui commented Nov 20, 2024

Hi @alina-jacob, As discussed, the optimal screen reader announcement in this case will be 1 page number of 11 pages.

We cannot use the format page number 1 of 11 pages, as it would announce the selected page number first, followed by the label.

Please let me know if this works for you.

@alina-jacob
Copy link
Member Author

Thanks for the update @preetibansalui, we can remove the word "number" to make the content less verbose.
So the new expected announcement would be 1, page, of 11 pages

@github-project-automation github-project-automation bot moved this from ⏱ Backlog to ✅ Done in Design System Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants