Skip to content

Commit ee251fd

Browse files
sstrubbergAlessandra Davila
andauthored
chore(TimePicker): updated size prop for v11 (#10944)
Co-authored-by: Alessandra Davila <aledavila@ibm.com>
1 parent f308fd7 commit ee251fd

File tree

4 files changed

+18
-13
lines changed

4 files changed

+18
-13
lines changed

packages/react/src/components/TimePicker/TimePicker.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,7 @@ export default class TimePicker extends Component {
9898
placeholder: PropTypes.string,
9999

100100
/**
101-
* Specify the size of the Time Picker. Currently supports either `sm`, 'md' (default) or 'lg` as an option.
102-
* TODO V11: remove `xl` (replaced with lg)
101+
* Specify the size of the Time Picker.
103102
*/
104103
size: PropTypes.oneOf(['sm', 'md', 'lg', 'xl']),
105104

packages/react/src/components/TimePicker/next/TimePicker.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ const TimePicker = React.forwardRef(function TimePicker(
2828
onBlur = () => {},
2929
pattern = '(1[012]|[1-9]):[0-5][0-9](\\s)?',
3030
placeholder = 'hh:mm',
31-
size,
31+
size = 'md',
3232
type = 'text',
3333
value,
3434
...rest
@@ -211,7 +211,7 @@ TimePicker.propTypes = {
211211
placeholder: PropTypes.string,
212212

213213
/**
214-
* Specify the size of the Time Picker. Currently supports either `sm`, 'md' (default) or 'lg` as an option.
214+
* Specify the size of the Time Picker.
215215
*/
216216
size: PropTypes.oneOf(['sm', 'md', 'lg']),
217217

packages/react/src/components/TimePicker/next/TimePicker.stories.js

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,15 +54,24 @@ import { Layer } from '../../Layer';
5454
export default {
5555
title: 'Components/TimePicker',
5656
component: TimePicker,
57+
argTypes: {
58+
size: {
59+
options: ['sm', 'md', 'lg'],
60+
control: { type: 'select' },
61+
},
62+
},
63+
args: {
64+
size: 'md',
65+
},
5766
subcomponents: {
5867
TimePickerSelect,
5968
SelectItem,
6069
},
6170
};
6271

63-
export const Default = () => {
72+
export const Default = (args) => {
6473
return (
65-
<TimePicker id="time-picker" labelText="Select a time">
74+
<TimePicker id="time-picker" labelText="Select a time" {...args}>
6675
<TimePickerSelect id="time-picker-select-1">
6776
<SelectItem value="AM" text="AM" />
6877
<SelectItem value="PM" text="PM" />
@@ -75,10 +84,10 @@ export const Default = () => {
7584
);
7685
};
7786

78-
export const WithLayer = () => {
87+
export const WithLayer = (args) => {
7988
return (
8089
<>
81-
<TimePicker id="time-picker" labelText="First layer">
90+
<TimePicker id="time-picker" labelText="First layer" {...args}>
8291
<TimePickerSelect id="time-picker-select-1">
8392
<SelectItem value="AM" text="AM" />
8493
<SelectItem value="PM" text="PM" />
@@ -89,7 +98,7 @@ export const WithLayer = () => {
8998
</TimePickerSelect>
9099
</TimePicker>
91100
<Layer>
92-
<TimePicker id="time-picker" labelText="Second layer">
101+
<TimePicker id="time-picker" labelText="Second layer" {...args}>
93102
<TimePickerSelect id="time-picker-select-1">
94103
<SelectItem value="AM" text="AM" />
95104
<SelectItem value="PM" text="PM" />
@@ -100,7 +109,7 @@ export const WithLayer = () => {
100109
</TimePickerSelect>
101110
</TimePicker>
102111
<Layer>
103-
<TimePicker id="time-picker" labelText="Third layer">
112+
<TimePicker id="time-picker" labelText="Third layer" {...args}>
104113
<TimePickerSelect id="time-picker-select-1">
105114
<SelectItem value="AM" text="AM" />
106115
<SelectItem value="PM" text="PM" />

packages/styles/scss/components/time-picker/_time-picker.scss

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,6 @@
8383
max-height: rem(32px);
8484
}
8585

86-
// TODO V11: Remove xl selector
87-
.#{$prefix}--time-picker--xl .#{$prefix}--select-input,
88-
.#{$prefix}--time-picker--xl .#{$prefix}--time-picker__input-field,
8986
.#{$prefix}--time-picker--lg .#{$prefix}--select-input,
9087
.#{$prefix}--time-picker--lg .#{$prefix}--time-picker__input-field {
9188
height: rem(48px);

0 commit comments

Comments
 (0)