Skip to content

Commit eb3dcf0

Browse files
rjhenriquezRicardo Henriquezkodiakhq[bot]
authored
fix(a11y): dap errors with MultiSelect.Filterable (#6906)
* fix(a11y): dap errors with MultiSelect.Filterable * chore(snapshot): update snapshots Co-authored-by: Ricardo Henriquez <Ricardo@Ricardos-MBP.lan> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
1 parent 583b137 commit eb3dcf0

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

packages/react/src/components/MultiSelect/FilterableMultiSelect.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -398,9 +398,9 @@ export default class FilterableMultiSelect extends React.Component {
398398
aria-controls={`${id}__menu`}
399399
aria-autocomplete="list"
400400
ref={(el) => (this.inputNode = el)}
401+
id={`${id}-input`}
401402
{...getInputProps({
402403
disabled,
403-
id,
404404
placeholder,
405405
onKeyDown: this.handleOnInputKeyDown,
406406
})}
@@ -423,7 +423,7 @@ export default class FilterableMultiSelect extends React.Component {
423423
</ListBox.Field>
424424
{isOpen && (
425425
<ListBox.Menu
426-
role="group"
426+
role="listbox"
427427
aria-label={ariaLabel}
428428
id={`${id}-menu`}>
429429
{sortItems(

packages/react/src/components/MultiSelect/__tests__/__snapshots__/FilterableMultiSelect-test.js.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ exports[`MultiSelect.Filterable should render 1`] = `
133133
autoComplete="off"
134134
className="bx--text-input bx--text-input--empty"
135135
disabled={false}
136-
id="test-filterable-multiselect"
136+
id="test-filterable-multiselect-input"
137137
onBlur={[Function]}
138138
onChange={[Function]}
139139
onKeyDown={[Function]}

0 commit comments

Comments
 (0)