Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(deprecations): add new page including upcoming deprecation details #4301

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Sep 27, 2024

Part of carbon-design-system/carbon#12497

Changelog

New

  • Add new page for deprecations, add details of upcoming deprecations
    • I purposely left this page out of the left nav for now. I don't think there's a strong case for discoverability of this page. The intent is to link to carbondesignsystem.com/deprecations from the deprecation message that will be visible on npmjs.com as well as developer terminal/consoles when installing the deprecated packages. but let me know what you think!
  • Update various references to v10 and deprecated packages across the site

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 6:51pm

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, I didn't realize we had all those links to v10 for the elements packages.

Do we need to add the Deprecations page to the nav?

@tay1orjones
Copy link
Member Author

@alisonjoseph Yeah I was surprised too 😱

I'm not opposed to adding it to the nav, just felt 50/50 to me if we'd want it there. Sorta feels like it shouldn't be discoverable, to instead have users hit that page only when they're guided there? Like from the npm deprecation message or the package readme's. What do you think? I also couldn't figure out where we'd want to put it in the left nav 🤔

Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing idea @tay1orjones! 🔥

I feel the deprecated section shares similarities with the feature flag regarding its timing and importance. Feature flag components become more prominent as a version nears its end, while deprecated components are most significant when a new version is released. The deprecated section will likely gain relevance once v12 is live, as users will start inquiring about which components have been deprecated.

Therefore, it might be a good idea to make this section accessible—either directly or indirectly—via navigation. We could explore potential placements, such as next to the Feature Flag section or under Releases. These are just some initial thoughts!

image

@tay1orjones
Copy link
Member Author

@Kritvi-bhatia17 great points, thanks for bringing them up!

These deprecations are slightly different than feature-flag-related deprecations. These docs relate to the larger/more broad package and package version "deprecations" which happen after a package's end-of-support date. These are different from deprecations within the packages (components, functions, etc.). We should discuss and figure out where those "intra-package" deprecations docs should live. I skew towards continuing to document them in situ at the package-level storybook, but maybe there is a place for some kind of content about them on the website.

The package and version deprecations here will be immediately relevant on Monday as we'll be doing a formal deprecation on npm for both these packages, as well as v10.x versions of the other @carbon/colors, etc.

One other thing regarding the left nav concern is I think it's beneficial for this url to be as short as possible. We'll be using it in the deprecation message on npm and it will be printed in developer consoles where space is limited. Example:

This package is no longer supported. More info at carbondesignsystem.com/deprecations

vs

This package is no longer supported. More info at carbondesignsystem.com/components/overview/deprecations/

@Kritvi-bhatia17
Copy link
Contributor

Oh, I see! Got it—thanks a lot, @tay1orjones, for such a detailed explanation.

If needed, we can discuss later how to handle feature-flag-related deprecations for both developers and designers. I believe there might already be a section for that on the website, but I’ll need to check; that’s a bit off-topic for now.

In any case, you guys have more knowledge and insight on this, will leave it up to y'll!

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tay1orjones that makes sense, thinking about it more I don't see a logical place to put it in the left nav. Maybe if we added another layer of navigation in the future under Frameworks we could link to it as a subpage of React, but for now its probably fine as is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of these cards are linking to the same page. Just confirming—should we be showing both the Resources cards, or is one enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants