Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

chore(codesandbox): clean the codesandbox deps #743

Merged
merged 2 commits into from
Nov 24, 2021
Merged

chore(codesandbox): clean the codesandbox deps #743

merged 2 commits into from
Nov 24, 2021

Conversation

abdonrd
Copy link
Collaborator

@abdonrd abdonrd commented Nov 3, 2021

Clean the codesandbox deps

Because this: #726

@abdonrd abdonrd requested a review from a team as a code owner November 3, 2021 17:39
@abdonrd abdonrd requested review from ariellalgilmore, IgnacioBecerra and DragosRistici and removed request for a team November 3, 2021 17:39
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 3, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components - React:
https://carbon-web-components-react.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/743/index.html

Built with commit: d85d142dbb7cd93f94ca2bb8dc6859c4360f0c8e

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 3, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/743/index.html

Built with commit: d85d142dbb7cd93f94ca2bb8dc6859c4360f0c8e

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 3, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components - Vue:
https://carbon-web-components-vue.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/743/index.html

Built with commit: d85d142dbb7cd93f94ca2bb8dc6859c4360f0c8e

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 4, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components - Angular:
https://carbon-web-components-angular.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/743/index.html

Built with commit: d85d142dbb7cd93f94ca2bb8dc6859c4360f0c8e

@abdonrd abdonrd requested a review from jeffchew November 4, 2021 14:10
@jeffchew
Copy link
Member

jeffchew commented Nov 4, 2021

We should probably hold on this until the next release is out.

@asudoh
Copy link
Collaborator

asudoh commented Nov 5, 2021

Weighing in; For this kind of change (bulk update to our CodeSandbox examples), recommended to run build integration test, at least locally.

@abdonrd
Copy link
Collaborator Author

abdonrd commented Nov 5, 2021

Weighing in; For this kind of change (bulk update to our CodeSandbox examples), recommended to run build integration test, at least locally.

Ok! But we also need to update for the release, right?

@jeffchew jeffchew changed the title chore: clean the codesandbox deps chore(codesandbox): clean the codesandbox deps Nov 5, 2021
@jeffchew
Copy link
Member

jeffchew commented Nov 5, 2021

Weighing in; For this kind of change (bulk update to our CodeSandbox examples), recommended to run build integration test, at least locally.

thank you @asudoh ! Always a good idea for this! Down the road, would like to have it run on every PR plus run e2e tests like we do currently with Carbon for IBM.com.

@asudoh
Copy link
Collaborator

asudoh commented Nov 5, 2021

Cool to clarify, the repo has two integration tests:

  • Build integration test: Tests the build artifacts with CodeSandbox (Seems disabled in CI somehow as of today)
  • UI integration tests: Tests user interaction with multiple browsers (Effectively e2e)

@abdonrd abdonrd force-pushed the codesandbox branch 3 times, most recently from 723075d to 648a974 Compare November 11, 2021 09:08
@abdonrd abdonrd force-pushed the codesandbox branch 3 times, most recently from 400aa1a to dc51e25 Compare November 19, 2021 14:36
jeffchew
jeffchew approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this one in!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Nov 24, 2021
abdonrd
abdonrd commented Nov 24, 2021
View reviewed changes
examples/codesandbox/angular/package.json Outdated
@@ -18,11 +18,7 @@
"@angular/platform-browser-dynamic": "^8.0.0",
"@angular/router": "^8.0.0",
"@babel/runtime": "^7.8.0",
"carbon-components": "~10.34.0",
"carbon-web-components": "^1.0.0",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffchew I was thinking... We should update it to this?

"carbon-web-components": "^1.19.0",

Because before that version, there were no dependencies.

@kodiakhq kodiakhq bot merged commit 0dadc0a into master Nov 24, 2021
@kodiakhq kodiakhq bot deleted the codesandbox branch November 24, 2021 19:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeffchew jeffchew jeffchew approved these changes

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@DragosRistici DragosRistici Awaiting requested review from DragosRistici DragosRistici was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abdonrd @ibmdotcom-bot @jeffchew @asudoh