Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): fix to marked dependency issues #8172

Merged
merged 8 commits into from
Feb 3, 2022
Merged

fix(deps): fix to marked dependency issues #8172

merged 8 commits into from
Feb 3, 2022

Conversation

jeffchew
Copy link
Member

@jeffchew jeffchew commented Jan 31, 2022 •
edited
Loading

Related Ticket(s)

Refs #8192

Description

This tries to address some integration issues involving the marked dependency.

  • Setting marked to nohoist in yarn workspaces configuration
  • Removed @storybook/addon-info
  • Upgraded jsdoc to latest

Changelog

Changed

  • package.json include nohoist
  • Upgraded jsdoc from services and utilities

Removed

  • Removed @storybook/addon-info from styles package

@jeffchew jeffchew added package: services Work necessary for the Carbon for IBM.com services package package: utilities Work necessary for the Carbon for IBM.com utilities package dev Needs some dev work labels Jan 31, 2022
@jeffchew jeffchew requested a review from a team as a code owner January 31, 2022 18:54
@jeffchew jeffchew requested a review from emyarod January 31, 2022 18:54
@jeffchew
Copy link
Member Author

We need to watch the web components codesandbox build to see if the integration issues are still there.

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 31, 2022 •
edited
Loading

Deploy preview created for package Utilities:
https://ibmdotcom-utilities.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/8172/index.html

Built with commit: 047a44560eef19a669e4bff1d07f9e8bf7b58467

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 31, 2022 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/8172/index.html

Built with commit: 047a44560eef19a669e4bff1d07f9e8bf7b58467

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 31, 2022 •
edited
Loading

Deploy preview created for package "Services":
https://ibmdotcom-services.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/8172/index.html

Built with commit: 047a44560eef19a669e4bff1d07f9e8bf7b58467

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 31, 2022 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8172/index.html

Built with commit: 047a44560eef19a669e4bff1d07f9e8bf7b58467

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 31, 2022 •
edited
Loading

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8172/index.html

Built with commit: 047a44560eef19a669e4bff1d07f9e8bf7b58467

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 31, 2022 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8172/index.html

Built with commit: 047a44560eef19a669e4bff1d07f9e8bf7b58467

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 31, 2022 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8172/index.html

Built with commit: 047a44560eef19a669e4bff1d07f9e8bf7b58467

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 31, 2022 •
edited
Loading

Deploy preview created for package "Web Components (Codesandbox Examples)":
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8172/index.html

Built with commit: 047a44560eef19a669e4bff1d07f9e8bf7b58467

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 31, 2022 •
edited
Loading

Deploy preview created for package "React (Codesandbox Examples)":
https://react-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8172/index.html

Built with commit: 047a44560eef19a669e4bff1d07f9e8bf7b58467

IgnacioBecerra
IgnacioBecerra approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@IgnacioBecerra IgnacioBecerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jeffchew for getting the fix for this nasty error in!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Feb 3, 2022
@jeffchew jeffchew merged commit c1bb7f5 into carbon-design-system:main Feb 3, 2022
@jeffchew jeffchew deleted the fix/marked-dep branch February 3, 2022 18:44
@IgnacioBecerra IgnacioBecerra mentioned this pull request Feb 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgnacioBecerra IgnacioBecerra IgnacioBecerra approved these changes

@emyarod emyarod Awaiting requested review from emyarod emyarod is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
dev Needs some dev work package: services Work necessary for the Carbon for IBM.com services package package: utilities Work necessary for the Carbon for IBM.com utilities package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffchew @ibmdotcom-bot @IgnacioBecerra