Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(masthead): fix undefined error in locale call #8142

Merged
merged 2 commits into from
Jan 26, 2022
Merged

fix(masthead): fix undefined error in locale call #8142

merged 2 commits into from
Jan 26, 2022

Conversation

jeffchew
Copy link
Member

Related Ticket(s)

No related issue

Description

There are a number of Uncaught (in promise) TypeError: Cannot convert undefined or null to object errors happening in the masthead/footer. This is an attempt to fix this.

Need to run the integration tests to see if this fixes the issues.

Changelog

Changed

  • Roll back axios to ~0.21.4

@jeffchew jeffchew added the dev Needs some dev work label Jan 25, 2022
@jeffchew jeffchew self-assigned this Jan 25, 2022
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 25, 2022 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/8142/index.html

Built with commit: 16ccf565832f65dbd6bc772a0c87a328d7329c5c

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 25, 2022 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8142/index.html

Built with commit: 16ccf565832f65dbd6bc772a0c87a328d7329c5c

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 25, 2022 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8142/index.html

Built with commit: 16ccf565832f65dbd6bc772a0c87a328d7329c5c

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 25, 2022 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8142/index.html

Built with commit: 16ccf565832f65dbd6bc772a0c87a328d7329c5c

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 25, 2022 •
edited
Loading

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8142/index.html

Built with commit: 16ccf565832f65dbd6bc772a0c87a328d7329c5c

@jeffchew jeffchew marked this pull request as ready for review January 25, 2022 17:52
@jeffchew jeffchew requested a review from a team as a code owner January 25, 2022 17:52
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 25, 2022 •
edited
Loading

Deploy preview created for package "Web Components (Codesandbox Examples)":
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8142/index.html

Built with commit: 16ccf565832f65dbd6bc772a0c87a328d7329c5c

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 25, 2022 •
edited
Loading

Deploy preview created for package "React (Codesandbox Examples)":
https://react-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8142/index.html

Built with commit: 16ccf565832f65dbd6bc772a0c87a328d7329c5c

ariellalgilmore
ariellalgilmore approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Jan 26, 2022
@jeffchew jeffchew merged commit ba3745c into carbon-design-system:main Jan 26, 2022
@jeffchew jeffchew deleted the fix/locale-call branch January 26, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariellalgilmore ariellalgilmore ariellalgilmore approved these changes

@oliviaflory oliviaflory Awaiting requested review from oliviaflory oliviaflory is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees

@jeffchew jeffchew

Labels
dev Needs some dev work Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffchew @ibmdotcom-bot @ariellalgilmore