Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): adding default package exports for services/utilities #7048

Merged
merged 3 commits into from
Sep 2, 2021
Merged

fix(node): adding default package exports for services/utilities #7048

merged 3 commits into from
Sep 2, 2021

Conversation

jeffchew
Copy link
Member

@jeffchew jeffchew commented Sep 1, 2021

Related Ticket(s)

Refs #6203

Description

This fixes an import issue for services and utilities if they are used in Node 14.

Changelog

Changed

  • Updated exports configuration for services and utilities

@jeffchew jeffchew requested a review from a team as a code owner September 1, 2021 22:36
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 1, 2021 •
edited
Loading

Deploy preview created for package Web Components - Codesandbox Examples:
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7048/

Built with commit: ef7779b5345b70cd871a57e7ce7084669861bee6

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Sep 1, 2021
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 1, 2021 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7048/index.html

Built with commit: ef7779b5345b70cd871a57e7ce7084669861bee6

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 1, 2021 •
edited
Loading

Deploy preview created for package Web Components - React Wrapper:
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7048/index.html

Built with commit: ef7779b5345b70cd871a57e7ce7084669861bee6

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 1, 2021 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7048/index.html

Built with commit: ef7779b5345b70cd871a57e7ce7084669861bee6

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 1, 2021 •
edited
Loading

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7048/index.html

Built with commit: ef7779b5345b70cd871a57e7ce7084669861bee6

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/7048/index.html

Built with commit: ef7779b5345b70cd871a57e7ce7084669861bee6

@kodiakhq kodiakhq bot merged commit abd793a into carbon-design-system:master Sep 2, 2021
@jeffchew jeffchew deleted the fix/package-exports branch September 13, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgnacioBecerra IgnacioBecerra IgnacioBecerra approved these changes

@RichKummer RichKummer Awaiting requested review from RichKummer

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffchew @ibmdotcom-bot @IgnacioBecerra