Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stripHTML): add check if there are no surrounding elements #6484

Merged
merged 2 commits into from
Jun 25, 2021
Merged

fix(stripHTML): add check if there are no surrounding elements #6484

merged 2 commits into from
Jun 25, 2021

Conversation

jeffchew
Copy link
Member

Related Ticket(s)

No related issue

Description

The stripHTML utility always assumes that there is a wrapping tag. However, in the cases when only a string is passed, it should just pass through without doing anything, rather than throwing an error.

Changelog

Changed

  • Add additional string check in stripHTML

@jeffchew jeffchew added package: utilities Work necessary for the Carbon for IBM.com utilities package dev Needs some dev work labels Jun 25, 2021
@jeffchew jeffchew added this to the Sprint 21-13 milestone Jun 25, 2021
@jeffchew jeffchew self-assigned this Jun 25, 2021
NSDrowned
NSDrowned approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@NSDrowned NSDrowned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Jun 25, 2021
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jun 25, 2021 •
edited
Loading

Deploy preview created for package Utilities:
https://ibmdotcom-utilities.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/6484/index.html

Built with commit: e4b685d39d643c62d44b96bc73f7ee71da317659

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jun 25, 2021 •
edited
Loading

Deploy preview created for package Web Components - React Wrapper:
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/6484/index.html

Built with commit: e4b685d39d643c62d44b96bc73f7ee71da317659

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/6484/index.html

Built with commit: e4b685d39d643c62d44b96bc73f7ee71da317659

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/6484/index.html

Built with commit: e4b685d39d643c62d44b96bc73f7ee71da317659

@kodiakhq kodiakhq bot merged commit 66a72e8 into carbon-design-system:master Jun 25, 2021
@jeffchew jeffchew deleted the fix/striphtml-check branch July 19, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NSDrowned NSDrowned NSDrowned approved these changes

Assignees

@jeffchew jeffchew

Labels
dev Needs some dev work package: utilities Work necessary for the Carbon for IBM.com utilities package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
Sprint 21-13
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffchew @ibmdotcom-bot @NSDrowned