-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(left-nav): refactor into left-nav-sections and include animations #6393
feat(left-nav): refactor into left-nav-sections and include animations #6393
Conversation
Deploy preview created for package Built with commit: 63743fdc6ca7770cc04eb3df0041e73ac764c125 |
Deploy preview created for package Built with commit: 63743fdc6ca7770cc04eb3df0041e73ac764c125 |
Deploy preview created for package Built with commit: 63743fdc6ca7770cc04eb3df0041e73ac764c125 |
…wen1/ibm-dotcom-library into feat/wc-left-nav-animations
Deploy preview created for package Built with commit: 63743fdc6ca7770cc04eb3df0041e73ac764c125 |
Deploy preview created for package Built with commit: 63743fdc6ca7770cc04eb3df0041e73ac764c125 |
…wen1/ibm-dotcom-library into feat/wc-left-nav-animations
Done
It should now focus on the back button when on the next panel. Also the
In web components, you should be able to get to the For React, it's coded a bit differently and user has to go back to the initial menu panel to access the
hmm yeah that's been like that since we created the left nav I believe. We can address this in another ticket.
Done
Addressed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one @annawen1! Just some really small fixes.
packages/web-components/src/components/masthead/left-nav-menu-section.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/masthead/left-nav-menu-section.ts
Outdated
Show resolved
Hide resolved
@shixiedesign The first issue is now addressed. The second one we can open a new ticket for.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌶️ 🌶️ 🌶️
Related Ticket(s)
Web Component: Change Mega Menu to include animation (back button & forward motion) #4831
[Left Nav: Web Components]: L1 items are visible when on L2 menu items #6209
Web component: Masthead-With custom data - Hybrid cloud options are missing from the menu options. #5135
Description
Refactor
left-nav
so all menu panels/sections are on the same level instead of nested.Align animations for forward and backward movement.
Changelog
New
left-nav-menu-section
component that handles all the focus of first element, back button functionalityChanged
left-nav-menu
andleft-nav-menu-item
left-nav-menu
to only render menu items that have a menucloud-masthead-composite
focuswrap
utility when focus doesn't hit start or end sentinel which allows the first menu item to focus when left-nav is expandedRemoved