feat(content-block): added mock markup for content-block-heading #6349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphaelamadeu-zz
requested review from
kennylam,
jeffchew,
annawen1 and
andysherman2121
|
Deploy preview created for package Built with commit: 0f6760c7e5e1528d6ffb10fcea786d8a4df61b1d |
jeffchew
reviewed
Jun 11, 2021
packages/web-components/src/components/content-block/content-block-heading.ts
Show resolved
Hide resolved
|
Deploy preview created for package Built with commit: 0f6760c7e5e1528d6ffb10fcea786d8a4df61b1d |
|
Deploy preview created for package Built with commit: 0f6760c7e5e1528d6ffb10fcea786d8a4df61b1d |
jeffchew
reviewed
Jun 14, 2021
jeffchew
reviewed
Jun 14, 2021
packages/web-components/src/components/content-block/content-block-heading.ts
Outdated
Show resolved
Hide resolved
jeffchew
reviewed
Jun 14, 2021
packages/web-components/src/components/content-block/content-block-paragraph.ts
Outdated
Show resolved
Hide resolved
jeffchew
reviewed
Jun 16, 2021
raphaelamadeu-zz
changed the title
jeffchew
added
the
Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
#6083
Description
I've added some light dom rendering for content-block-heading and content-block-paragraph, so its content can be accessed and read by SEO tools.
I've also made a utility that strips HTML from a string, as we needed that to get the content to be rendered.