fix(ipcinfo): setting domain for the ipcinfo cookie #3839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a discrepency identified where the cookie was being set under `www.ibm.com` domain on the IBM.com homepage, whereas v18 was setting it under `.ibm.com` on all other pages. When returning to the homepage and clicking the logo, this caused the server-side level redirect rule to kick in and create a garbled homepage url and causing a 404 to occur.
jeffchew
added
the
package: utilities
|
Deploy preview created for package Built with commit: 9259d181940a2e2ac213d5681ccec947ccd1e8c3 |
|
Deploy preview created for package Built with commit: 9259d181940a2e2ac213d5681ccec947ccd1e8c3 |
|
Deploy preview created for package Built with commit: 9259d181940a2e2ac213d5681ccec947ccd1e8c3 |
kennylam
approved these changes
Sep 2, 2020
kennylam
added
the
Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Refs #3838
Description
There was a discrepency identified where the cookie was being set under
www.ibm.comdomain on the IBM.com homepage, whereas v18 was setting itunder
.ibm.comon all other pages. When returning to the homepage andclicking the logo, this caused the server-side level redirect rule to
kick in and create a garbled homepage url and causing a 404 to occur.
Changelog
Changed
ipcinfocookie