fix(MegaMenu): prevent menu items from overlapping #3565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annawen1
added
package: react
|
Deploy preview created for package Built with commit: 13390c9ede92779699df534956913091e27fb4e3 |
|
Deploy preview created for package Built with commit: 13390c9ede92779699df534956913091e27fb4e3 |
|
Deploy preview created for package Built with commit: 13390c9ede92779699df534956913091e27fb4e3 |
annawen1
requested review from
jeffchew,
kennylam,
andysherman2121,
ariellalgilmore and
raphaelamadeu-zz
kennylam
approved these changes
Aug 13, 2020
jeffchew
added
the
Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Masthead / mega menu – content overlapping #3519
Description
Menu Items were overlapping at certain breakpoint. Add utility to calculate total width of the masthead and set the media query to hide and show elements.
Changelog
New
calculateTotalWidthutility to find total width of elements passed in.styletag within the<head>element to hide/show items