fix(VideoPlayer): fix for mocking VideoPlayerAPI in storyshots #2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CI checks were running with obfuscated Kaltura IDs since they are passed in as environment variables, so this is setting up a mock for the VideoPlayerAPI service to return back mocked data instead.
jeffchew
requested review from
kennylam,
asudoh,
raphaelamadeu-zz,
annawen1 and
andysherman2121
jeffchew
added
the
package: react
…arbon-design-system#2691) When using the video card in <LinkList />, it's pulling in the generating the kaltura thumbnail by default. Need to pass in a prop, disableImage to prevent the thumbnail from being generated.
The CI checks were running with obfuscated Kaltura IDs since they are passed in as environment variables, so this is setting up a mock for the VideoPlayerAPI service to return back mocked data instead.
…ideoplayer-mock # Conflicts: # packages/react/src/__tests__/__snapshots__/storyshots.test.js.snap
|
Deploy preview created for package Built with commit: f0213c12b71ba0438a7e1a73bb7b6b72288de61f |
|
Deploy preview created for package Built with commit: f0213c12b71ba0438a7e1a73bb7b6b72288de61f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Refs #2688
Description
The CI checks were running with obfuscated Kaltura IDs since they are
passed in as environment variables, so this is setting up a mock for
the VideoPlayerAPI service to return back mocked data instead.
Changelog
Changed
@carbon/ibmdotcom-servicesin React package