Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cardlink): adds cardlink #2506

Merged
merged 3 commits into from
May 28, 2020
Merged

feat(cardlink): adds cardlink #2506

merged 3 commits into from
May 28, 2020

Conversation

kennylam
Copy link
Member

Related Ticket(s)

Fixes #2235

Description

This adds opinionated CardLink component.

Changelog

New

  • CardLink

Changed

  • LocaleModal and CTA now use CardLink instead of Card

Removed

  • CTASection story CSS

@kennylam kennylam added the package: react Work necessary for the Carbon for IBM.com react components package label May 26, 2020
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented May 26, 2020 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/2506/index.html

Built with commit: 58eef416681799bd7ac3148b2cc5bf11a6145031

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented May 26, 2020 •
edited
Loading

Deploy preview created for package "React (experimental)":
https://ibmdotcom-react-experimental.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/2506/index.html

Built with commit: 58eef416681799bd7ac3148b2cc5bf11a6145031

@kennylam kennylam requested a review from jeffchew May 27, 2020 14:30
@kennylam kennylam requested a review from jeffchew May 27, 2020 19:34
@kennylam
feat(cardlink): adds cardlink
e9d5f0f 
parent 7ee8c8c
author Kenny Lam <kennylam@protonmail.com> 1590522209 -0400
committer Kenny Lam <kennylam@protonmail.com> 1590680475 -0400

chore(localemodal): use cardLink for locale regions
@jeffchew jeffchew changed the title Feat/cardlink feat(cardlink): adds cardlink May 28, 2020
@kennylam kennylam merged commit bfae7e0 into carbon-design-system:master May 28, 2020
@kennylam kennylam deleted the feat/cardlink branch May 28, 2020 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffchew jeffchew jeffchew approved these changes

@raphaelamadeu-zz raphaelamadeu-zz Awaiting requested review from raphaelamadeu-zz

@guilhermelMoraes guilhermelMoraes Awaiting requested review from guilhermelMoraes

Assignees
No one assigned
Labels
package: react Work necessary for the Carbon for IBM.com react components package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pattern: Develop Card link - Prod level version
3 participants
@kennylam @ibmdotcom-bot @jeffchew