Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missed extensions to on imports #10288

Merged
merged 7 commits into from
Apr 27, 2023
Merged

fix: add missed extensions to on imports #10288

merged 7 commits into from
Apr 27, 2023

Conversation

abdonrd
Copy link
Contributor

@abdonrd abdonrd commented Mar 30, 2023

Description

Add missed extenstions to on imports

Changelog

Changed

  • Add missed extenstions to on imports

@abdonrd abdonrd requested a review from a team as a code owner March 30, 2023 00:20
@abdonrd abdonrd requested review from kennylam and RichKummer March 30, 2023 00:20
@abdonrd abdonrd changed the title fix: add missed extenstions to on imports fix: add missed extensions to on imports Mar 30, 2023
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 30, 2023 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10288/index.html

Built with commit: a2ab097c21d5c59abe4870dd4355a4f7949b82c9

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 30, 2023 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/10288/index.html

Built with commit: a2ab097c21d5c59abe4870dd4355a4f7949b82c9

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 30, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10288/index.html

Built with commit: a2ab097c21d5c59abe4870dd4355a4f7949b82c9

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Mar 30, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10288/index.html

Built with commit: a2ab097c21d5c59abe4870dd4355a4f7949b82c9

ariellalgilmore
ariellalgilmore approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

RichKummer
RichKummer approved these changes Mar 30, 2023
View reviewed changes
Copy link

@RichKummer RichKummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RichKummer RichKummer mentioned this pull request Apr 7, 2023
Closed
@kennylam kennylam merged commit e3ab4a7 into carbon-design-system:feat/cwc-v2 Apr 27, 2023
@abdonrd abdonrd deleted the feat/cwc-v2-extensions branch April 27, 2023 04:25
kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Dec 4, 2023
@abdonrd @kennylam
fix: add missed extensions to on imports (carbon-design-system#10288)
7e8ef9f 
* fix: add missed extenstions to on imports

* fix: add missed extensions to settings imports

---------

Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@abdonrd @kennylam
fix: add missed extensions to on imports (carbon-design-system#10288)
6782c36 
* fix: add missed extenstions to on imports

* fix: add missed extensions to settings imports

---------

Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichKummer RichKummer RichKummer approved these changes

@ariellalgilmore ariellalgilmore ariellalgilmore approved these changes

@kennylam kennylam Awaiting requested review from kennylam kennylam was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@abdonrd @ibmdotcom-bot @RichKummer @ariellalgilmore @kennylam