Skip to content

Commit d154911

Browse files
authored
fix(ipcInfo): set encoding for ipcinfoCookie (#10505)
1 parent 2a44fa4 commit d154911

File tree

2 files changed

+16
-4
lines changed

2 files changed

+16
-4
lines changed

packages/utilities/src/utilities/ipcinfoCookie/__tests__/ipcinfoCookie.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ describe('ipcinfo cookie utility', () => {
2020
it('should fetch the ipcInfo cookie and return a neat object', () => {
2121
Object.defineProperty(window.document, 'cookie', {
2222
writable: true,
23-
value: 'ipcInfo=cc%253DUS%253Blc%253Den',
23+
value: 'ipcInfo=cc%3DUS%3Blc%3Den',
2424
});
2525

2626
const info = {

packages/utilities/src/utilities/ipcinfoCookie/ipcinfoCookie.js

+15-3
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,17 @@ class ipcinfoCookie {
2929
* const info = ipcinfoCookie.get();
3030
*/
3131
static get() {
32-
const ipcinfo = Cookies.get(_cookieName);
32+
const cookiesDecode = Cookies.withConverter({
33+
read: function (value) {
34+
return decodeURIComponent(value);
35+
},
36+
});
37+
38+
const ipcinfo = cookiesDecode.get(_cookieName);
3339
if (ipcinfo) {
3440
let cc;
3541
let lc;
36-
const info = decodeURIComponent(ipcinfo).split(';');
42+
const info = ipcinfo.split(';');
3743
info.map((code) => {
3844
const itemParts = code.split('=');
3945
if (itemParts[0] === 'cc') cc = itemParts[1];
@@ -60,7 +66,13 @@ class ipcinfoCookie {
6066
static set({ cc, lc }) {
6167
const info = `cc=${cc};lc=${lc}`;
6268

63-
Cookies.set(_cookieName, encodeURIComponent(info), {
69+
const cookiesEncode = Cookies.withConverter({
70+
write: function (value) {
71+
return encodeURIComponent(value);
72+
},
73+
});
74+
75+
cookiesEncode.set(_cookieName, info, {
6476
expires: 365,
6577
domain: '.ibm.com',
6678
});

0 commit comments

Comments
 (0)