Skip to content

Commit 616f68b

Browse files
committed
fix(utility): abstracted one loop from the same-height function
1 parent bed7f89 commit 616f68b

File tree

3 files changed

+3
-15
lines changed

3 files changed

+3
-15
lines changed

packages/utilities/src/utilities/sameHeight/sameHeight.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -28,19 +28,15 @@ function sameHeight(elemCollection, minSize = false) {
2828
? parseFloat(breakpoints[minSize].width) * baseFontSize
2929
: 0;
3030
if (window.innerWidth > targetWidth) {
31-
elemArr.forEach(elem => {
32-
elem.style.height = 'auto';
33-
});
3431
let targetHeight = 0;
35-
3632
elemArr.forEach(elem => {
33+
elem.style.height = 'auto';
3734
elem.offsetHeight > targetHeight
3835
? (targetHeight = elem.offsetHeight)
3936
: false;
4037
});
4138

4239
elemArr.forEach(elem => {
43-
elem.offsetHeight == targetHeight;
4440
elem.style.height = targetHeight + 'px';
4541
});
4642
} else {

packages/utilities/src/utilities/sameHeight/sameheight.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -28,19 +28,15 @@ function sameHeight(elemCollection, minSize = false) {
2828
? parseFloat(breakpoints[minSize].width) * baseFontSize
2929
: 0;
3030
if (window.innerWidth > targetWidth) {
31-
elemArr.forEach(elem => {
32-
elem.style.height = 'auto';
33-
});
3431
let targetHeight = 0;
35-
3632
elemArr.forEach(elem => {
33+
elem.style.height = 'auto';
3734
elem.offsetHeight > targetHeight
3835
? (targetHeight = elem.offsetHeight)
3936
: false;
4037
});
4138

4239
elemArr.forEach(elem => {
43-
elem.offsetHeight == targetHeight;
4440
elem.style.height = targetHeight + 'px';
4541
});
4642
} else {

packages/utilities/src/utilities/sameheight/sameheight.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -28,19 +28,15 @@ function sameHeight(elemCollection, minSize = false) {
2828
? parseFloat(breakpoints[minSize].width) * baseFontSize
2929
: 0;
3030
if (window.innerWidth > targetWidth) {
31-
elemArr.forEach(elem => {
32-
elem.style.height = 'auto';
33-
});
3431
let targetHeight = 0;
35-
3632
elemArr.forEach(elem => {
33+
elem.style.height = 'auto';
3734
elem.offsetHeight > targetHeight
3835
? (targetHeight = elem.offsetHeight)
3936
: false;
4037
});
4138

4239
elemArr.forEach(elem => {
43-
elem.offsetHeight == targetHeight;
4440
elem.style.height = targetHeight + 'px';
4541
});
4642
} else {

0 commit comments

Comments
 (0)