Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflow Menu not working in IE #833

Closed
Vinoth-LearningThings opened this issue Feb 21, 2020 · 4 comments · Fixed by #840
Closed

Overflow Menu not working in IE #833

Vinoth-LearningThings opened this issue Feb 21, 2020 · 4 comments · Fixed by #840

Comments

@Vinoth-LearningThings
Copy link
Contributor

Overflow menu is not showing up in IE

Detailed description

cv-overflow-menu is not showing up in IE browser. Works in Chrome & Edge

Bug

cv-overflow-menu

Overflow menu should show up in all the browsers

IE11
"@carbon/vue": "^2.17.1" & "carbon-components": "^10.7.3"

Steps to reproduce the issue

  1. Use cv-overflow-menu component in vue application
  2. Launch the application in IE
  3. Click the overflow-menu-icon

Additional information

<cv-overflow-menu
              :flip-menu="true"
              :up="false"
              :offset="{ left: 0, top: 0 }"
              @click.native.stop
              class="actions-menu"
            >
              <span ref="overflowMenuItem">
                <cv-overflow-menu-item
                  primary-focus
                  v-for="(overflowAction, idx) in overflowActions"
                  :key="idx"
                  @click="overflowMenuEvents(index, $event, item)"
                >{{ overflowAction }}</cv-overflow-menu-item>
              </span>
            </cv-overflow-menu>

overflowActions: ["Action 1", "Action 2", "Action 3", "Remove"]
@Vinoth-LearningThings
Copy link
Contributor Author

Analyzed the issue and found out that the usage of window.scrollX and window.scrollY causing the issue in IE. Seems the properties scrollX and scrollY doesn't support the IE browser.

https://developer.mozilla.org/en-US/docs/Web/API/Window/scrollY

Using window.pageXOffset and window.pageYOffset resolved the issue for me.

Can we get this fix in next version?

@lee-chase
Copy link
Member

Sure @Vinoth-LearningThings will be a couple of days before I can take a look. Feel free to submit a PR which checks for the existence of scrollX/scrollY and defering to pageXOffset/pageYOffset which I may be able to review tomorrow.

Include interactive tooltip in any fix.

@lee-chase
Copy link
Member

@Vinoth-LearningThings let me know if that works for you canary just published.

@Vinoth-LearningThings
Copy link
Contributor Author

@lee-chase Yup. Looks good to me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants