Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(file-uploader): mark files with invalid types/formats #1231

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

trickstival
Copy link
Contributor

Fix #1223

What did you do?

  • made the accept attr a prop
  • checked if dropped files have the same mime type or extensions as the informed in the accept prop
  • added special case for jpeg files

Why did you do it?

because there was a comment there saying it should be implemented and an issue for it.
I inspired my code in the carbon-react implementation

How have you tested it?

I created unit tests and tested with the local storybook

Were docs updated if needed?

  • N/A
  • No
  • Yes

@netlify
Copy link

netlify bot commented Jul 28, 2021

✔️ Deploy Preview for carbon-components-vue ready!

🔨 Explore the source changes: fe2aa42

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-vue/deploys/6101d0316915010007a58fa2

😎 Browse the preview: https://deploy-preview-1231--carbon-components-vue.netlify.app

Copy link
Member

@lee-chase lee-chase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR

@lee-chase lee-chase merged commit dc3d8e1 into carbon-design-system:main Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File Uploader Error Scenario
2 participants