Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cv-grid, cv-row, cv-column #1038

Merged
merged 2 commits into from
Oct 6, 2020
Merged

feat: add cv-grid, cv-row, cv-column #1038

merged 2 commits into from
Oct 6, 2020

Conversation

janhassel
Copy link
Member

Closes #1028

adds three new components: cv-grid, cv-row and cv-column to make it easier for developers to utilize the Carbon grid styles.

Changelog

A       packages/core/src/components/cv-grid/cv-column.vue
A       packages/core/src/components/cv-grid/cv-grid-notes.md
A       packages/core/src/components/cv-grid/cv-grid.vue
A       packages/core/src/components/cv-grid/cv-row.vue
A       packages/core/src/components/cv-grid/index.js
M       packages/core/src/index.js
A       storybook/stories/cv-grid-story.js
A       storybook/stories/cv-grid-story.scss

@janhassel
Copy link
Member Author

janhassel commented Oct 2, 2020

@lee-chase The styles for the narrow grid were added in carbon-components@10.17.0, hence the narrow grid and the wide grid look the same in the storybook right now.

I tested with v10.17.0 locally and it matches the style shown in the react storybook.

image

@netlify
Copy link

netlify bot commented Oct 2, 2020

Deploy preview for carbon-components-vue ready!

Built with commit faea78f

https://deploy-preview-1038--carbon-components-vue.netlify.app

@lee-chase lee-chase merged commit 2ba3a5f into carbon-design-system:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add utility components for grid column and row as per React implementation
2 participants