Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated modules #2005

Closed
Tracked by #2081
pcotret opened this issue Apr 24, 2023 · 6 comments
Closed
Tracked by #2081

Deprecated modules #2005

pcotret opened this issue Apr 24, 2023 · 6 comments
Labels
build & packaging Build system and packaging related python bindings
Milestone

Comments

@pcotret
Copy link

pcotret commented Apr 24, 2023

pkg_resources

https://github.com/capstone-engine/capstone/blob/master/bindings/python/capstone/__init__.py#L269
https://discuss.python.org/t/deprecating-importlib-resources-legacy-api/11386

pkg_resources seems to be deprecated from Python 3.9.

distutils

https://peps.python.org/pep-0632/

distutils is deprecated since Python 3.10 and no longer installed in Python 3.12 (https://docs.python.org/3.12/whatsnew/3.12.html).

For instance, it's used in Python bindings:
https://github.com/capstone-engine/capstone/blob/next/bindings/python/capstone/__init__.py#L346

Discussion

Should we just put a warning somewhere like "works with Python x.xx" or maybe thinking about an alternative for these modules?

@pcotret pcotret changed the title Deprecated distutils module Deprecated modules Apr 25, 2023
@kabeor
Copy link
Member

kabeor commented May 11, 2023

This will be fix before we release v5.0.

@peace-maker
Copy link
Contributor

@kabeor What's the path forward for Capstone 5.0? Migrate away from the deprecated libraries? I'd like to help with this if it's the only thing left blocking a release.

@kabeor
Copy link
Member

kabeor commented Jun 8, 2023

@peace-maker Yes, this issue is the only left thing I believe:)

@peace-maker
Copy link
Contributor

What's the minimum python version you want to support?

@XVilka
Copy link
Contributor

XVilka commented Jun 8, 2023

@peace-maker according to #1993 (comment) they plan to support Python 2.7 as the lowest version. As for Python 3, see https://endoflife.date/python - looks like it's either 3.7 (EOL in 2 weeks), or 3.8

@Rot127
Copy link
Collaborator

Rot127 commented Sep 4, 2024

Closed by #2400

@Rot127 Rot127 closed this as completed Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build & packaging Build system and packaging related python bindings
Projects
None yet
Development

No branches or pull requests

5 participants