From 7cfac685b0646f80453d4d4dfbd05a1d13eb1564 Mon Sep 17 00:00:00 2001 From: Alex Date: Fri, 5 Jan 2024 11:31:55 -0500 Subject: [PATCH 1/4] Update OAuthProviderHandler.swift Fix swapped "link" and "signIn" methods for oauth --- .../ios/Plugin/Handlers/OAuthProviderHandler.swift | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/authentication/ios/Plugin/Handlers/OAuthProviderHandler.swift b/packages/authentication/ios/Plugin/Handlers/OAuthProviderHandler.swift index d831fb82..40b24961 100644 --- a/packages/authentication/ios/Plugin/Handlers/OAuthProviderHandler.swift +++ b/packages/authentication/ios/Plugin/Handlers/OAuthProviderHandler.swift @@ -53,8 +53,8 @@ class OAuthProviderHandler: NSObject { return } if let credential = credential { - self.pluginImplementation.handleSuccessfulLink(credential: credential, idToken: nil, nonce: nil, - accessToken: nil, serverAuthCode: nil, displayName: nil, authorizationCode: nil) + self.pluginImplementation.handleSuccessfulSignIn(credential: credential, idToken: nil, nonce: nil, + accessToken: nil, displayName: nil, authorizationCode: nil, serverAuthCode: nil) } } } @@ -66,8 +66,8 @@ class OAuthProviderHandler: NSObject { return } if let credential = credential { - self.pluginImplementation.handleSuccessfulSignIn(credential: credential, idToken: nil, nonce: nil, - accessToken: nil, displayName: nil, authorizationCode: nil, serverAuthCode: nil) + self.pluginImplementation.handleSuccessfulLink(credential: credential, idToken: nil, nonce: nil, + accessToken: nil, serverAuthCode: nil, displayName: nil, authorizationCode: nil) } } } From 203a3de5524cf9939e65ef089e0fa9cd86d54b57 Mon Sep 17 00:00:00 2001 From: Alex Strasser Date: Wed, 10 Jan 2024 09:20:38 -0500 Subject: [PATCH 2/4] npm run changeset --- .changeset/fifty-eels-notice.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/fifty-eels-notice.md diff --git a/.changeset/fifty-eels-notice.md b/.changeset/fifty-eels-notice.md new file mode 100644 index 00000000..d611c1cf --- /dev/null +++ b/.changeset/fifty-eels-notice.md @@ -0,0 +1,5 @@ +--- +'@capacitor-firebase/authentication': minor +--- + +Fix swapped link and signIn functions for oauth flow sign in From fc8b23b1a1671254c0fc88bad59c68c7bc85bcbc Mon Sep 17 00:00:00 2001 From: Robin Genz Date: Wed, 10 Jan 2024 18:00:57 +0100 Subject: [PATCH 3/4] Update .changeset/fifty-eels-notice.md --- .changeset/fifty-eels-notice.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/fifty-eels-notice.md b/.changeset/fifty-eels-notice.md index d611c1cf..8713da71 100644 --- a/.changeset/fifty-eels-notice.md +++ b/.changeset/fifty-eels-notice.md @@ -2,4 +2,4 @@ '@capacitor-firebase/authentication': minor --- -Fix swapped link and signIn functions for oauth flow sign in +fix(ios): sign-in with oauth provider failed From 2c680d83ab8b280f3a78c1899190676a15f722c7 Mon Sep 17 00:00:00 2001 From: Robin Genz Date: Wed, 10 Jan 2024 18:01:02 +0100 Subject: [PATCH 4/4] Update .changeset/fifty-eels-notice.md --- .changeset/fifty-eels-notice.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/fifty-eels-notice.md b/.changeset/fifty-eels-notice.md index 8713da71..33ce82da 100644 --- a/.changeset/fifty-eels-notice.md +++ b/.changeset/fifty-eels-notice.md @@ -1,5 +1,5 @@ --- -'@capacitor-firebase/authentication': minor +'@capacitor-firebase/authentication': patch --- fix(ios): sign-in with oauth provider failed