Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(authentication): Facebook login accessToken is undefined #31

Closed
mostafa3ly opened this issue Mar 1, 2022 · 2 comments · Fixed by #55
Closed

bug(authentication): Facebook login accessToken is undefined #31

mostafa3ly opened this issue Mar 1, 2022 · 2 comments · Fixed by #55
Labels
bug/fix Something isn't working package: authentication

Comments

@mostafa3ly
Copy link

Plugin version:

@robingenz/capacitor-firebase-authentication ^0.4.1

Platform(s):

Android
iOS

Current behavior:

Facebook sign in is successfully done when calling signInWithFacebook() but the result is an object of {prodvider: ... , idToken: ...}
and there is no accessToken returned in the result which is needed to link native layer with JS sdk by calling signInWithCredintials()
described here

Expected behavior:

accessToken returned in signinWithFacebook() result to use it in JS sdk signin

Steps to reproduce:

Related code:

  const result = await FirebaseAuthentication.signInWithFacebook();
  const credential = FacebookAuthProvider.credential(result.credential?.accessToken);
  const auth = getAuth();
  await signInWithCredential(auth, credential);

Other information:

Capacitor doctor:

Latest Dependencies:

  @capacitor/cli: 3.4.1
  @capacitor/core: 3.4.1
  @capacitor/android: 3.4.1
  @capacitor/ios: 3.4.1

Installed Dependencies:

  @capacitor/cli: 3.4.1
  @capacitor/core: 3.4.1
  @capacitor/android: 3.4.1
  @capacitor/ios: 3.4.1

[success] Android looking great! 👌
[error] Xcode is not installed
@robingenz robingenz added the bug/fix Something isn't working label Mar 3, 2022
@robingenz
Copy link
Member

Hi @mostafa3ly,
thank you for your request.
I was able to reproduce the issue. As soon as I have time I will publish a fix.

@robingenz robingenz transferred this issue from robingenz/capacitor-firebase-authentication Mar 23, 2022
@robingenz robingenz changed the title bug: Facebook login accessToken is undefined bug(authentication): Facebook login accessToken is undefined Mar 23, 2022
@robingenz
Copy link
Member

Feel free to test the new dev version and let me know if it works:

npm i @capacitor-firebase/authentication@0.2.0-dev.eeac0a7.1648649641

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug/fix Something isn't working package: authentication
Projects
None yet
2 participants