From f18c6f0cfd5d3d4eee458c18e49968a1f8804f80 Mon Sep 17 00:00:00 2001 From: Alex Date: Wed, 10 Jan 2024 12:02:04 -0500 Subject: [PATCH] fix(authentication): sign-in with oauth provider failed (#538) * Update OAuthProviderHandler.swift Fix swapped "link" and "signIn" methods for oauth * npm run changeset * Update .changeset/fifty-eels-notice.md * Update .changeset/fifty-eels-notice.md --------- Co-authored-by: Robin Genz --- .changeset/fifty-eels-notice.md | 5 +++++ .../ios/Plugin/Handlers/OAuthProviderHandler.swift | 8 ++++---- 2 files changed, 9 insertions(+), 4 deletions(-) create mode 100644 .changeset/fifty-eels-notice.md diff --git a/.changeset/fifty-eels-notice.md b/.changeset/fifty-eels-notice.md new file mode 100644 index 00000000..33ce82da --- /dev/null +++ b/.changeset/fifty-eels-notice.md @@ -0,0 +1,5 @@ +--- +'@capacitor-firebase/authentication': patch +--- + +fix(ios): sign-in with oauth provider failed diff --git a/packages/authentication/ios/Plugin/Handlers/OAuthProviderHandler.swift b/packages/authentication/ios/Plugin/Handlers/OAuthProviderHandler.swift index d831fb82..40b24961 100644 --- a/packages/authentication/ios/Plugin/Handlers/OAuthProviderHandler.swift +++ b/packages/authentication/ios/Plugin/Handlers/OAuthProviderHandler.swift @@ -53,8 +53,8 @@ class OAuthProviderHandler: NSObject { return } if let credential = credential { - self.pluginImplementation.handleSuccessfulLink(credential: credential, idToken: nil, nonce: nil, - accessToken: nil, serverAuthCode: nil, displayName: nil, authorizationCode: nil) + self.pluginImplementation.handleSuccessfulSignIn(credential: credential, idToken: nil, nonce: nil, + accessToken: nil, displayName: nil, authorizationCode: nil, serverAuthCode: nil) } } } @@ -66,8 +66,8 @@ class OAuthProviderHandler: NSObject { return } if let credential = credential { - self.pluginImplementation.handleSuccessfulSignIn(credential: credential, idToken: nil, nonce: nil, - accessToken: nil, displayName: nil, authorizationCode: nil, serverAuthCode: nil) + self.pluginImplementation.handleSuccessfulLink(credential: credential, idToken: nil, nonce: nil, + accessToken: nil, serverAuthCode: nil, displayName: nil, authorizationCode: nil) } } }