From 1105fcd3a1d816a0a19376dc9b0b2a52c3f5c7c5 Mon Sep 17 00:00:00 2001 From: Robin Genz Date: Wed, 14 Feb 2024 13:54:49 +0100 Subject: [PATCH] fix(firestore): add `null` check on Android --- .changeset/dirty-parrots-beam.md | 5 +++++ .../plugins/firebase/firestore/FirebaseFirestore.java | 4 +++- 2 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 .changeset/dirty-parrots-beam.md diff --git a/.changeset/dirty-parrots-beam.md b/.changeset/dirty-parrots-beam.md new file mode 100644 index 00000000..7e1f0f3c --- /dev/null +++ b/.changeset/dirty-parrots-beam.md @@ -0,0 +1,5 @@ +--- +'@capacitor-firebase/firestore': patch +--- + +fix(android): add `null` check diff --git a/packages/firestore/android/src/main/java/io/capawesome/capacitorjs/plugins/firebase/firestore/FirebaseFirestore.java b/packages/firestore/android/src/main/java/io/capawesome/capacitorjs/plugins/firebase/firestore/FirebaseFirestore.java index f91d761c..5c08e158 100644 --- a/packages/firestore/android/src/main/java/io/capawesome/capacitorjs/plugins/firebase/firestore/FirebaseFirestore.java +++ b/packages/firestore/android/src/main/java/io/capawesome/capacitorjs/plugins/firebase/firestore/FirebaseFirestore.java @@ -111,7 +111,9 @@ public void getCollection(@NonNull GetCollectionOptions options, @NonNull NonEmp Query query = this.firestoreInstance.collection(reference); if (compositeFilter != null) { Filter filter = compositeFilter.toFilter(); - query = query.where(filter); + if (filter != null) { + query = query.where(filter); + } } if (queryConstraints.length > 0) { for (QueryNonFilterConstraint queryConstraint : queryConstraints) {