Improve the detection of global/root object #804
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to jashkenas/underscore#2152. We were using a similar approach to
async
s current one in underscore until jashkenas/underscore#2153.The two main benefits of this change are:
strict
mode and some tooling (see Use Function("return this") to get global? jashkenas/underscore#2152)WebWorker
support, you can't usewindow
in aWebWorker
but you can useself
Aside: here's the detection method from lodash