Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote build: do not truncate snap name in log file #4781

Closed
jnsgruk opened this issue May 1, 2024 · 3 comments · Fixed by canonical/craft-application#351
Closed

remote build: do not truncate snap name in log file #4781

jnsgruk opened this issue May 1, 2024 · 3 comments · Fixed by canonical/craft-application#351
Labels
bug Actual bad behavior that don't fall into maintenance or documentation triaged

Comments

@jnsgruk
Copy link
Member

jnsgruk commented May 1, 2024

Bug Description

When using remote build, the name of the log file returned is <snap name>_<arch>-<timestamp>.txt from what I can see.

In cases where the snap has a -, this name get's truncated. For example, the log file I received when remote building signal-desktop was named signal_arm64-<date>.txt rather than signal-desktop_arm64-<date>.txt

To Reproduce

git clone https://github.com/snapcrafters/signal-desktop
cd signal-desktop
snapcraft remote-build

Environment

Ubuntu 22.04, Snapcraft 8.2.0

snapcraft.yaml

n/a

Relevant log output

https://github.com/snapcrafters/signal-desktop/actions/runs/8834314689/job/24473525329#step:2:683

Additional context

No response

@jnsgruk jnsgruk added the bug Actual bad behavior that don't fall into maintenance or documentation label May 1, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-2869.

This message was autogenerated

@mr-cal
Copy link
Collaborator

mr-cal commented May 1, 2024

@lengau
Copy link
Contributor

lengau commented May 3, 2024

@mr-cal that was a quick & dirty hack to get the project name in the PoC that made it into production accidentally. We need to pull the project name out of the project itself.

@mr-cal mr-cal added the triaged label Aug 21, 2024
@mr-cal mr-cal changed the title New remote-build returns log files that truncates snap name in file name remote build: do not truncate snap name in log file Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Actual bad behavior that don't fall into maintenance or documentation triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants