add getting and setting assertions #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3v3nmw
force-pushed
the
add-and-set-assertions
branch
3 times, most recently
from
46cbe86
to
fd7fc7a
Compare
Perfect5th
requested changes
Jan 29, 2024
tests/integration/conftest.py
Outdated
| def hello_world_snap_declaration_assertion() -> (str, Dict[str, str]): | ||
| path = "tests/integration/assets/hello_world_snap_declaration.assert" | ||
| with open(path, "rb") as f: | ||
| yield (f.read().decode(), HELLO_WORLD_SNAP_DECLARATION_ASSERTION) |
There was a problem hiding this comment.
what's the purpose of opening the file in binary mode if we're immediately going to decode it?
st3v3nmw
force-pushed
the
add-and-set-assertions
branch
from
fd7fc7a
to
d2aec1a
Compare
st3v3nmw
force-pushed
the
add-and-set-assertions
branch
from
d2aec1a
to
3941752
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the code changes in
snap_httpare relatively few, but the integration testing was a bit hectic since there's no "official" way to remove an assertion