Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ingress, catalogue relations to terraform modules #245

Closed
sed-i opened this issue Dec 4, 2024 · 4 comments · Fixed by #259
Closed

Add ingress, catalogue relations to terraform modules #245

sed-i opened this issue Dec 4, 2024 · 4 comments · Fixed by #259

Comments

@sed-i
Copy link
Contributor

sed-i commented Dec 4, 2024

We need to have mimir, tempo listed on the catalogue page.

Depends on:

This would involve adding ingress relations to mimir, tempo, as they are currently missing from the terraform module.
This may be a bit involved: after manually relating mimir to traefik, I am getting a 404 from nginx for all mimir endpoints.

References:

@sed-i sed-i changed the title Add catalogue relations to terraform modules Add ingress, catalogue relations to terraform modules Dec 4, 2024
@sed-i
Copy link
Contributor Author

sed-i commented Dec 6, 2024

This could have been happening because the /status path is already used by an nginx endpoint mapping.
We shouldn't shadow known workload paths with our custom ones.
The trouble is that /status may be a hard dep for the nginx exporter.

@simskij
Copy link
Member

simskij commented Dec 10, 2024

Why do we want to have tempo? It has no UI. Mimir potentially makes sense, but I'd honestly skip it. I'm sure I've asked for this at some point, but I think we can skip this.

@lucabello
Copy link
Contributor

@simskij @sed-i canonical/tempo-coordinator-k8s-operator#93 added some form of that for Tempo. Mimir has the same one, while Loki has a "simpler" UI not for the generic memberlist, but for the distributor ring:

Screenshot-2025-01-13_11-23

Another alternative, as we discussed in a separate meeting, is to add an empty link, explaining the lack of UI in the catalogue item description.

How do we want to do this?

@lucabello
Copy link
Contributor

We're gonna go for the empty links for now, for both Mimir and Loki, and eventually change it in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants